elk icon indicating copy to clipboard operation
elk copied to clipboard

Oned compaction breaks with new orthogonal self-loops

Open uruuru opened this issue 5 years ago • 4 comments
trafficstars

Applying LEFT compaction to the selfloop_orthogonal.elkt test file yields a) invalid hitboxes if the nodes have no particularly specified size b) a broken layout (all nodes and edges stacked to the very left) if all nodes have size 20, 20

As far as I remember, the graph worked with the old self loops.

uruuru avatar Apr 02 '20 19:04 uruuru

I checked using elk live with different java versions. The issue occurs starting with 0.6.0.

@le-cds, 0.5.0 already includes "new splines" right? Anything else that changed from 0.5.0 to 0.6.0 w.r.t. self loops?

uruuru avatar Apr 23 '20 18:04 uruuru

@uruuru 0.6.0 shipped my rewritten self loop code. Regarding 0.5.0, what exactly do you mean by new splines?

le-cds avatar Apr 24 '20 15:04 le-cds

The self loops in 0.5.0 and 0.6.0 look roughly the same. Maybe 0.6.0 is "your" new code :)? We had the results of a master's thesis in there before, right?

uruuru avatar Apr 24 '20 15:04 uruuru

Yep, you're right. 0.5.0 shipped the master's thesis code. My rewrite shipped with 0.6.0, but it did not alter the major concepts.

le-cds avatar Apr 26 '20 09:04 le-cds