elk icon indicating copy to clipboard operation
elk copied to clipboard

Selfloops edge labels cannot be inlined

Open soerendomroes opened this issue 1 year ago • 1 comments

Describe the bug Feedback edges are not inlined, as seen here.

Expected behavior I expected the "test" label to be inlined similar to "test2"

ELK Version 0.8.1 in elklive and local master branch. This should have been fixed in 0.9.0. https://eclipse.dev/elk/downloads/releasenotes/release-0.9.0.html (Inline edge labels are now correctly centered (hopefully).). Maybe this issue did only tackle this for non-self-loops?

Additional context See https://github.com/lf-lang/lingua-franca/issues/2259

soerendomroes avatar Apr 13 '24 16:04 soerendomroes

The issue persists since self-loop labels do not appear as nodes in LabelSideSelector

soerendomroes avatar Apr 13 '24 17:04 soerendomroes

I guess, the SelfLoopRouter should consider this property.

soerendomroes avatar Jul 24 '25 13:07 soerendomroes

This seems to be a little complicated. SelfHyperLoopLabels seems to handle to concrete label coordinates. However, the edge routes also need to consider the position of the labels during edge routing.

soerendomroes avatar Jul 25 '25 09:07 soerendomroes