eclipse-collections icon indicating copy to clipboard operation
eclipse-collections copied to clipboard

Reduce code duplication by making a few classes extend AbstractRichIterable.

Open motlin opened this issue 7 years ago • 3 comments

Reduce code duplication by making a few classes extend AbstractRichIterable, including:

  • ImmutableArrayStack
  • primitiveObjectHashMap
  • abstractImmutablePrimitiveObjectMap
  • immutablePrimitiveObjectHashMap
  • MutablePrimitiveObjectMap

motlin avatar Apr 21 '17 12:04 motlin

ImmutableArrayStack<T> implements ImmutableStack<T> which conflicts with AbstractRichIterable<T> at least for countByEach(Function<? super T, ? extends Iterable<V>>).

MutablePrimitiveObjectMap<V> is an interface so can't extend AbstractRichIterable<V>.

kedar-joshi avatar Jul 16 '20 16:07 kedar-joshi

I wanted to take this up but not sure if it's still valid requirement.

kedar-joshi avatar Jul 16 '20 16:07 kedar-joshi

It's still valid! The conflicts are real bugs that should be fixed. You're right about interfaces that can't extend a class.

motlin avatar Jul 28 '20 01:07 motlin