Add a test of Verify derived from JUnit's test for Assert.

[motlin]

The idea is that this new test won't change in #1729 as long as the changes there are source compatible. cc @Desislav-Petrov

[Desislav-Petrov]

@motlin I'm thinking we should probably merge this after https://github.com/eclipse-collections/eclipse-collections/pulls, alongside the Verify uplift?

[motlin]

@motlin I'm thinking we should probably merge this after eclipse-collections/eclipse-collections/pulls, alongside the Verify uplift?

I tried cherry picking the JUnit 5 changes on top and they don't compile, because methods like Verify.assertArrayEquals no longer have a string as their first parameter (it moved to the last parameter).

Ideally this should land first, so we can see every source breaking change.

[motlin]

@donraab I think that https://github.com/eclipse-collections/eclipse-collections/pull/1729 is basically ready to go but that this one ought to land first. WDYT?

[motlin]

@donraab I have no implementation plan for Verify. I just want to increase test coverage of the API. When we change it, whether we break source compatibility or preserve it, I want it to be visible in tests.

[donraab]

@donraab I have no implementation plan for Verify. I just want to increase test coverage of the API. When we change it, whether we break source compatibility or preserve it, I want it to be visible in tests.

Ok, makes sense.

[motlin]

LGTM. There is a failing JavaDoc build, but once that is fixed looks good to merge.

The Javadoc failure looks like a bug in Java 11. The other Javadoc build using the EA build continues to pass.

[motlin]

I tried a bunch of things to get the Javadoc 11 build to pass. I eventually gave up and added a Javadoc 17 build which passed on the first try.

[Desislav-Petrov]

@motlin - are u still planning to merge that?