Migrating Verify to Junit5

Open Desislav-Petrov opened this issue 1 year ago • 4 comments

Final migration PR @motlin and we can call it success.

Dec 09 '24 22:12 Desislav-Petrov

sry @motlin wasn't previously fully ready for review that's why I left it as a draft but should be good now - thanks for looking at it.

Dec 14 '24 21:12 Desislav-Petrov

Thanks for the suggestion @motlin - implemented. Could you please take another look?

Dec 18 '24 21:12 Desislav-Petrov

@motlin thanks for questioning some of the stuff I have done, it got me to dig a bit deeper and as a result I've restructured the PR.

To cut a long story short, I didn't realise we run maven by default with --add-opens java.base/java.lang=ALL-UNNAMED. Believe all comments should be addressed now.

Jan 02 '25 21:01 Desislav-Petrov

Thanks for the review - should be addressed now @motlin

Jan 05 '25 16:01 Desislav-Petrov