eclipse-collections icon indicating copy to clipboard operation
eclipse-collections copied to clipboard

Published 20 hours ago • verified publisher icon eclipse

Junit5 Migration Part 1 - #1576

Open Desislav-Petrov opened this issue 1 year ago • 3 comments

Part of the Junit5 migration preparation.

  • Moves imports to static to reduce change size for future PRs
  • Fixes a bug in an iterator test explained in here
  • Removes any junit4 syntax like @Test(expected = ) as it's not supported in junit5

Desislav-Petrov avatar May 15 '24 21:05 Desislav-Petrov

@donraab @motlin hopefully this one is easier to review and is a good step towards the ultimate goal

Desislav-Petrov avatar May 16 '24 19:05 Desislav-Petrov

Hi @Desislav-Petrov, thanks! I started taking a look and have a general question. It looks like only assertEquals and assertThrows are made static imports. Is it not necessary to make assertTrue, assertFalse, assertSame static imports as well?

donraab avatar May 16 '24 20:05 donraab

I think we should land the three items separately. If you don't mind, I'll split this up into three separate PRs.

motlin avatar May 17 '24 12:05 motlin

@Desislav-Petrov @motlin Is this PR still valid? It hasn't been updated since May. Please close if this is outdated now. Thanks!

donraab avatar Sep 15 '24 02:09 donraab

Not needed - closing, thx for flagging

Desislav-Petrov avatar Sep 15 '24 08:09 Desislav-Petrov