eclipse-collections icon indicating copy to clipboard operation
eclipse-collections copied to clipboard

Documentation added in 2-Collection_Containers.adoc file for Bags

Open sandip1805 opened this issue 3 years ago • 5 comments

Provided example for creating bags using different ways and also provided example of using different set of methods available inside it.

#1387

sandip1805 avatar Dec 22 '22 16:12 sandip1805

Hi @sandip1805, this section should be for primitive bags (e.g. IntBag/MutableIntBag/ImmutableIntBag, DoubleBag/MutableDoubleBag/ImmutableDoubleBag, etc.). MutableBag is an object bag and would be documented in a different section.

donraab avatar Dec 22 '22 23:12 donraab

Ohh my bad, I will update it today and commit it.

Thanks & Regards, Sandip Patel +91 9727930925

On Fri, 23 Dec 2022, 5:20 am Donald Raab, @.***> wrote:

Hi @sandip1805 https://github.com/sandip1805, this section should be for primitive bags (e.g. IntBag/MutableIntBag/ImmutableIntBag, DoubleBag/MutableDoubleBag/ImmutableDoubleBag, etc.). MutableBag is an object bag and would be documented in a different section.

— Reply to this email directly, view it on GitHub https://github.com/eclipse/eclipse-collections/pull/1416#issuecomment-1363444570, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMYCDGQIMAFQKZOBS7L4XTWOTSKRANCNFSM6AAAAAATG4NEYE . You are receiving this because you were mentioned.Message ID: @.***>

sandip1805 avatar Dec 23 '22 02:12 sandip1805

Hi @sandip1805, this section should be for primitive bags (e.g. IntBag/MutableIntBag/ImmutableIntBag, DoubleBag/MutableDoubleBag/ImmutableDoubleBag, etc.). MutableBag is an object bag and would be documented in a different section.

Hi @donraab , I have incorporated suggested changes, could you please have a look and provide suggestion if any?

sandip1805 avatar Dec 24 '22 13:12 sandip1805

Hi @donraab , Build is failing with below reason, can you suggest what is causing issue here?

06:08:20:502 [INFO] Eclipse Collections Parent Project ................. FAILURE [01:59 min] 06:08:20:503 [INFO] Eclipse Collections Code Generator ................. SUCCESS [ 3.425 s] 06:08:20:504 [INFO] Eclipse Collections Code Generator Maven Plugin .... SUCCESS [ 3.339 s] 06:08:20:506 [INFO] Eclipse Collections API ............................ SUCCESS [ 12.958 s] 06:08:20:507 [INFO] Eclipse Collections Main Library ................... SUCCESS [ 48.336 s] 06:08:20:509 [INFO] Eclipse Collections Test Utilities ................. SUCCESS [ 4.720 s] 06:08:20:510 [INFO] Eclipse Collections Fork Join Utilities ............ SUCCESS [ 3.598 s] 06:08:20:511 [INFO] ------------------------------------------------------------------------ 06:08:20:512 [INFO] BUILD FAILURE 06:08:20:513 [INFO] ------------------------------------------------------------------------ 06:08:20:514 [INFO] Total time: 05:14 min 06:08:20:514 [INFO] Finished at: 2023-01-02T06:08:20Z 06:08:20:515 [INFO] ------------------------------------------------------------------------ Error: 0:582 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:aggregate (default-cli) on project eclipse-collections-parent: An error has occurred in Javadoc report generation: Error: 0:600 [ERROR] Exit code: 1 - Loading source files for package org.eclipse.collections.codegenerator.tools...

sandip1805 avatar Jan 13 '23 16:01 sandip1805

@sandip1805 Please squash your commits and rebase your PR. That should address the build failures as they were fixed in a another PR.

donraab avatar Jan 17 '23 00:01 donraab