eclipse-collections icon indicating copy to clipboard operation
eclipse-collections copied to clipboard
verified publisher icon eclipse

Add missing empty with comparator methods

Open Desislav-Petrov opened this issue 3 years ago • 5 comments

Desislav-Petrov avatar May 03 '22 17:05 Desislav-Petrov

hi @donraab - would appreciate a PR if u have a moment

Desislav-Petrov avatar May 03 '22 19:05 Desislav-Petrov

Could you link to the issue this fixes, with something like Fixes #1328 in the commit message?

motlin avatar May 03 '22 21:05 motlin

@motlin Sure - done

Desislav-Petrov avatar May 04 '22 18:05 Desislav-Petrov

Hi @Desislav-Petrov, took a look at this and should be simple enough to review and merge now since next planned release is a major release.

donraab avatar Aug 10 '22 04:08 donraab

hi @donraab - rebased now - thanks

Desislav-Petrov avatar Aug 11 '22 08:08 Desislav-Petrov

Hi @Desislav-Petrov, I think you need to fetch and rebase again. It looks like you are behind a few commits.

donraab avatar Aug 15 '22 13:08 donraab

hi @donraab - checked history, looks like it should be good now

Desislav-Petrov avatar Aug 15 '22 16:08 Desislav-Petrov