eclipse-collections icon indicating copy to clipboard operation
eclipse-collections copied to clipboard

Remove primitive iterable dependencies on Long/Int interval class

Open prathasirisha opened this issue 3 years ago • 2 comments

prathasirisha avatar Mar 30 '22 18:03 prathasirisha

Looking into this now. Looks like the implementation dependency issues are:

import org.eclipse.collections.impl.lazy.primitive.CollectIntToObjectIterable;
import org.eclipse.collections.impl.lazy.primitive.LazyIntIterableAdapter;
import org.eclipse.collections.impl.lazy.primitive.ReverseIntIterable;
import org.eclipse.collections.impl.lazy.primitive.SelectIntIterable;

donraab avatar Mar 30 '22 19:03 donraab

@prathasirisha I think looking at this we may have to move all generated lazy primitive Iterable types to the object impl jar. There is no other simpler solution. The templates I think we will need to move all generate code in org.eclipse.collections.impl.lazy.primitive.

The following are the templates that I could find:

collectPrimitiveIterable.stg abstractLazyPrimitiveIterable.stg chunkPrimitiveIterable.stg collectPrimitiveToObjectIterable.stg collectPrimitiveToPrimitiveIterable.stg flatCollectPrimitiveToObjectIterable.stg lazyPrimitiveIterableAdapter.stg reversePrimitiveIterable.stg selectPrimitiveIterable.stg tapPrimitiveIterable.stg

Found these utility classes as well after looking at some dependencies:

lazyPrimitiveIterate.stg primitiveIteratorIterate.stg primitiveIterableIterate.stg

In addition, we'll have to break all direct implementation dependencies between these and other primitive implementation classes. I'll start working on breaking the dependencies.

donraab avatar Mar 30 '22 19:03 donraab