dash-licenses icon indicating copy to clipboard operation
dash-licenses copied to clipboard

Consider making pre-built .jar available

Open marcdumais-work opened this issue 4 years ago • 7 comments

Is there an easy alternative to building dash-licenses from sources? I'd like to have it run as part of our project's CI, and would rather not have to build it each time. It would be great if instead we could use e.g. wget or curl to fetch the latest version from some official location.

marcdumais-work avatar Aug 19 '21 15:08 marcdumais-work

Yup. It's time to make this happen.

waynebeaton avatar Aug 19 '21 16:08 waynebeaton

The build does push the bits to our Nexus instance.

curl -L "https://repo.eclipse.org/service/local/artifact/maven/redirect?r=dash-licenses&g=org.eclipse.dash&a=org.eclipse.dash.licenses&v=LATEST" -o license.jar

But... we should probably still push it to download.eclipse.org. And it's probably time to do an actual release. So I'll leave this open for now.

waynebeaton avatar Aug 19 '21 16:08 waynebeaton

I think it's then mostly a matter of documenting where to get the jar to consider this issue as fixed. #123 covers that.

mickaelistria avatar Dec 02 '21 16:12 mickaelistria

@mickaelistria this issue is about procuring an already build .jar, e.g. to use dash-licenses in CI, without building it ourselves. I do not think #123 currently covers that use-case.

marcdumais-work avatar Dec 02 '21 19:12 marcdumais-work

We are using Wayne's suggested URL above, to fetch a prebuilt dash-license jar, during Theia's CI, and it works well enough, so it's not pressing for us to get an official release.

marcdumais-work avatar Dec 02 '21 19:12 marcdumais-work

There is already such a jar available for download. #123 puts the link in the doc.

mickaelistria avatar Dec 02 '21 19:12 mickaelistria

I do not think #123 currently covers that use-case.

Sorry @mickaelistria, I had missed part of your patch - the documentation is satisfactory. For my part, I do not need more at the moment. When there eventually is an official releases, we'll switch to using that instead. I do not object to closing this issue.

marcdumais-work avatar Dec 02 '21 19:12 marcdumais-work