dash-licenses icon indicating copy to clipboard operation
dash-licenses copied to clipboard

False positive on call-mvn-license-check github workflow

Open zulus opened this issue 1 year ago • 4 comments

Previously i reported in wrong place: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4353

Dash keeps complaining about PDT licenses, but no new libs has been added since a long time: https://github.com/eclipse-pdt/pdt/actions/runs/8052772404

In default actions result I see Plugin validations issues detected * org.apache.maven.plugins:maven-site-plugin:3.12.1 but this plugin is automatically added by maven (visible via help:effective-pom), I checked for example wildwebdeveloper project (help:effective-pom also reports this plugin but no problems in license check)

I tried empty pull request with "/request-license-review" but without luck : https://github.com/eclipse-pdt/pdt/pull/269 and https://github.com/eclipse-pdt/pdt/actions/runs/9210361818 (vetting review-summary is empty)

zulus avatar May 23 '24 15:05 zulus

The summary files are dated February 2024.

AFAICT, the build is failing while trying to resolve a dependency.

https://github.com/eclipse-pdt/pdt/actions/runs/9210361818/job/25337188139#step:11:51

waynebeaton avatar May 23 '24 21:05 waynebeaton

Correct url with recent error: https://github.com/eclipse-pdt/pdt/actions/runs/8052422043/job/21992505636

zulus avatar May 24 '24 08:05 zulus

Now complain about old eclipse project (org.eclipse.ptp.rdt.sync) : https://github.com/eclipse-pdt/pdt/actions/runs/9236342263/job/25412087069 (RDT sync)

zulus avatar May 25 '24 15:05 zulus

Correct url with recent error: https://github.com/eclipse-pdt/pdt/actions/runs/8052422043/job/21992505636

The date is Feb 26.

image

When we retired the Eclipse PTP project, the ability to automatically associating its contents with the project broke. I've added some hints; it should scan clean now.

org.apache.maven.plugins:maven-site-plugin:3.12

AFAICT, this is unrelated to the Eclipse Dash License Tool.

waynebeaton avatar May 25 '24 20:05 waynebeaton