dartboard icon indicating copy to clipboard operation
dartboard copied to clipboard

Flutter SDK preference control misbehaves

Open cybersearch2 opened this issue 5 years ago • 2 comments

I am testing the 'wip_flutter' branch. When I use the 'Browse' button on the Flutter SDK preference field, the text remains blank after having made the selection. I am running Eclipse on Windows and assume the cause of this bug is operating-system-specific. An initial investigation reveals that the first event to occur after dismissing the Directory Dialog is a focus event and validation of the text control contents commences before the text control has been updated.

I also see the directory validation involves performing file operations, so I propose showing a busy cursor while the validation happens in the background so as not to block the UI thread.

I will present a a pull request once a fix is available.

cybersearch2 avatar Jan 25 '20 23:01 cybersearch2

Thanks for the report.

The whole branch is kind of outdated, as I have been experimenting with a fix for an issue (#165) we ran into in the platform. Which involved moving a lot of the separated logic back to the base package. I will hopefully be able to push these changes in the next couple of days and update you on the progress here. After that this issue should be resolved though.

jonas-jonas avatar Jan 26 '20 10:01 jonas-jonas

Thanks for the update. A fix is now ready to be offered as a pull request. It applies to both Dart and Flutter preferences as they are very similar to each other. Both launch a command shell to test that Dart is installed which is inadmissible inside a button-click handler.

I have moved the command shell code inside a busy cursor and that makes the edit field behave as expected. I also removed the default button from the Flutter page as there is no suitable default.

cybersearch2 avatar Jan 27 '20 03:01 cybersearch2