dartboard icon indicating copy to clipboard operation
dartboard copied to clipboard

Webdev Support

Open jonas-jonas opened this issue 5 years ago • 5 comments

Dart projects that are supposed to be run in the browser, need to be launched using the webdev CLI tool. This needs to be supported in the launch configurations.

For this we should somehow detect if the project depends on build_web_compilers. This can either done

  1. by parsing the pubspec.yaml file or
  2. by looking at the output of pub deps -s compact (also relevant for #109)

I'm not sure yet, what would be the better option.

If the detection detects such a project, there should be another Run as entry titled Run as webdev application, which launches the webdev cli in the current project. Also; there are two commands relevant here webdev serve and webdev build. Both should be supported.

jonas-jonas avatar Jul 26 '19 09:07 jonas-jonas

@jonas-jonas I am interested to work on it. If you are not started yet.

lak-proddev avatar Jul 31 '19 05:07 lak-proddev

No, feel free to start work on it.

Lakshminarayana Nekkanti [email protected] schrieb am Mi., 31. Juli 2019, 07:40:

@jonas-jonas https://github.com/jonas-jonas I am interested to work on it. If you are not started yet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse/dartboard/issues/110?email_source=notifications&email_token=ABKITH5LGEWXOQYLQCVPDK3QCEQUBA5CNFSM4IHCA5JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3GEOZQ#issuecomment-516704102, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKITHZC3GU67STAC5AOUFTQCEQUBANCNFSM4IHCA5JA .

jonas-jonas avatar Jul 31 '19 05:07 jonas-jonas

Also note, that webdev should be invoked using the pub global run command. See the stagehand branch for a how to as it should be the same commands.

jonas-jonas avatar Jul 31 '19 11:07 jonas-jonas

I think these are the sub-tasks.

  • [ ] Detect Webdev support should be enabled for the project.
  • [ ] Provide Launch configuration
    • [ ] webdev serve support
    • [ ] webdev build support

lak-proddev avatar Aug 06 '19 05:08 lak-proddev

Yes, looks good to me. Please use https://github.com/eclipse/dartboard/blob/master/org.eclipse.dartboard/src/org/eclipse/dartboard/util/PubUtil.java when instantiating a new ProcessBuilder so you have the PUB_ENVIRONMENT variable set.

jonas-jonas avatar Aug 07 '19 18:08 jonas-jonas