chemclipse icon indicating copy to clipboard operation
chemclipse copied to clipboard

Published 20 hours ago • verified publisher icon eclipse

Use proper identifiers as identifiers

Open Mailaender opened this issue 11 months ago • 1 comments

https://github.com/eclipse/chemclipse/issues/1707

Mailaender avatar Mar 20 '24 11:03 Mailaender

Keep the identifier as they are, otherwise the ILibraryService to retrieve the reference spectrum would fail again:

private static final String IDENTIFIER = "Scan Maxima Detector UI"; // $NON-NLS-N$
public static final String IDENTIFIER = "Alkanes Identifier"; // $NON-NLS-N$
public static final String IDENTIFIER = "Manual"; // $NON-NLS-N$
String NIST_IDENTIFIER = "NIST (extern)"; // $NON-NLS-N$

Example file saved with Alkanes Identifier:

Screenshot from 2024-03-20 17-03-43

Identifier changed to org.eclipse.chemclipse.chromatogram.xxd.calculator.supplier.amdiscalri leads to a missing "Comparison Scan" reference:

Screenshot from 2024-03-20 17-05-13

eselmeister avatar Mar 20 '24 16:03 eselmeister