che-che4z-lsp-for-cobol icon indicating copy to clipboard operation
che-che4z-lsp-for-cobol copied to clipboard

Published 20 hours ago • verified publisher icon eclipse

Usage SQL type in cobol

Open ilidio-lopes opened this issue 10 months ago • 2 comments

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Checklist:

  • [x] Each of my commits contains one meaningful change
  • [x] I have performed rebase of my branch on top of the development
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] I have checked my code and corrected any misspellings

ilidio-lopes avatar Apr 19 '24 12:04 ilidio-lopes

We should also check if these newly added verbs in the lexer be available for coloring and auto completion.

For autocompletion verbs needs to be added to https://github.com/eclipse-che4z/che-che4z-lsp-for-cobol/blob/development/server/engine/src/main/resources/LanguageKeywords.txt

And for coloring, it should be added to https://github.com/eclipse-che4z/che-che4z-lsp-for-cobol/blob/development/clients/cobol-lsp-vscode-extension/syntaxes/COBOL.tmLanguage.json under cobol-general-keyword

ap891843 avatar Apr 23 '24 07:04 ap891843

#866

ilidio-lopes avatar Apr 24 '24 08:04 ilidio-lopes

Looks good to me. Please rebase with development

ap891843 avatar May 30 '24 08:05 ap891843

There are more types of host variables that need to be supported. See https://www.ibm.com/docs/en/SSEPEK_12.0.0/pdf/db2z_12_apsgbook.pdf page 664. The name of the section is Host variables in COBOL.

VitGottwald avatar May 30 '24 15:05 VitGottwald

This is an SQL feature, but it is coded in the main COBOL parser.

VitGottwald avatar Jun 04 '24 08:06 VitGottwald

Please, rename the PR to SQL: Result Set Locators.

VitGottwald avatar Jun 04 '24 08:06 VitGottwald

Please, rename the PR to SQL: Result Set Locators.

the PR handles #866 and not result set locator

ap891843 avatar Jun 04 '24 08:06 ap891843

When merging this PR, make sure to squash it and include a link to the compiler documentation https://www.ibm.com/docs/en/db2-for-zos/13?topic=cobol-host-variables-in#db2z_hostvariablecobol__title__20 .

The commit should be feat: SQL: Result set locators.

VitGottwald avatar Jun 04 '24 09:06 VitGottwald

Please, rename the PR to SQL: Result Set Locators.

the PR handles #866 and not result set locator

But it includes code for Result Set Locators.

VitGottwald avatar Jun 04 '24 09:06 VitGottwald

Please, rename the PR to SQL: Result Set Locators.

the PR handles #866 and not result set locator

The syntax SQL TYPE syntax is much richer than what is coded here. Result set locators are one small piece of it.

VitGottwald avatar Jun 04 '24 09:06 VitGottwald

I will removed the "Result Set Locators" changes from this pr a create a new one

ilidio-lopes avatar Jun 04 '24 09:06 ilidio-lopes

@ilidio-lopes are changes in this PR, still relevant ?

ap891843 avatar Jun 18 '24 10:06 ap891843