che-che4z-lsp-for-cobol icon indicating copy to clipboard operation
che-che4z-lsp-for-cobol copied to clipboard

Add more SQL dialects (Oracle/Pro*COBOL, postgresql)

Open GitMensch opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Support for non-DB2 dialects (of course: not run on the mainframe...)

Describe the solution you'd like A duplication of the now existing db2 dialect #2120, adjusted to those dialects.

Describe alternatives you've considered Use another extension or somehow (?) configure the extension to ignore EXEC SQL completely, apart from the variable references.

GitMensch avatar Dec 06 '23 22:12 GitMensch

It seems this should get the custom-dialect label.

GitMensch avatar Dec 20 '23 13:12 GitMensch

Hello, please try the latest 2.1.0 version. With this one, you can disable SQL analysis in the settings. We wonder if you would be interested in creating your own dialect with our guidance? We are more than happy to assist you in this effort.

zimlu02 avatar Dec 20 '23 16:12 zimlu02

'How to' blog post: https://medium.com/modern-mainframe/vs-code-language-server-extension-for-cobol-preprocessors-34f10c91558b

zimlu02 avatar Jan 11 '24 09:01 zimlu02

A custom extension does not make much sense for something as global as this with the idea to also add it to the pull down for sql dialect (from a quick look, I'm not sure that this is exposed for the custom dialects in the first place). It would be more reasonable to copy the DB2 one and make the pgsql/procob one similar as possible, maybe refactor to have identical parts only once.

Note: I do think that a bunch of entries from https://github.com/eclipse-che4z/che-che4z-lsp-for-cobol/blob/development/server/engine/src/main/resources/LanguageKeywords.txt should be moved to https://github.com/eclipse-che4z/che-che4z-lsp-for-cobol/blob/development/server/engine/src/main/resources/LanguageKeywords_sql.txt, no?

GitMensch avatar Sep 03 '24 13:09 GitMensch