che-che4z-lsp-for-cobol
che-che4z-lsp-for-cobol copied to clipboard
eclipse
Feature/task provider for compile
When testing with invalid APIML token, this is what the terminal looks like:
Nicely coloured output. Thank you!
A few comments:
- The jobname column is redundant. It is the same in all rows. Instead the green message Job completed. ... could say Job
completed, return code: CC 0000 - The first green line is not needed, please remove it
- The columns of the table are not aligned (spool-id should be aligned to the right, others to the left)
- Please, swap the
- Instead of the
column, please use - Please, use the following column order: Spool-id, DDname, Stepname, Procstep
- SYSPRINT at ... should be changed to Listing stored at ... and come before the list of errors.
After doing some more usability testing I believe that we should drop the "saveListing" and "listingLocation" configuration properties. Instead we should use vscode.ExtensionContext.storagePath folder to store the listings.
If the folder does not exist, we should create it on activation and create a listings subfolder to store the listings. If it exists we should clean (delete) the listings subfolder. The retrieved listings should then be stored in the listings subfolder a ${hostname}/${jobid}.txt files during a session. They will stay there to VScode reload (or extension de-activation followed by activation). For the deletion, please, use deleteFile vscode api. Unlike 'node' APIs it is guaranteed to work in all supported environements where vscode runs.
The extension context is provided to the extension by vscode as an argument on activate.
Please, add listFiles: boolean task configuration property with default true. If false, the table of DDs would not be printed to the output.
Nicely coloured output. Thank you!
A few comments:
- The jobname column is redundant. It is the same in all rows. Instead the green message Job completed. ... could say Job completed, return code: CC 0000
- The first green line is not needed, please remove it
- The columns of the table are not aligned (spool-id should be aligned to the right, others to the left)
- Please, swap the
- Instead of the column, please use
- Please, use the following column order: Spool-id, DDname, Stepname, Procstep
- SYSPRINT at ... should be changed to Listing stored at ... and come before the list of errors.
Updated as below
When testing with invalid APIML token, this is what the terminal looks like:
Updated, tested with other error
After doing some more usability testing I believe that we should drop the "saveListing" and "listingLocation" configuration properties. Instead we should use
vscode.ExtensionContext.storagePathfolder to store the listings.If the folder does not exist, we should create it on activation and create a
listingssubfolder to store the listings. If it exists we should clean (delete) thelistingssubfolder. The retrieved listings should then be stored in thelistingssubfolder a${hostname}/${jobid}.txtfiles during a session. They will stay there to VScode reload (or extension de-activation followed by activation). For the deletion, please, use deleteFile vscode api. Unlike 'node' APIs it is guaranteed to work in all supported environements where vscode runs.The extension context is provided to the extension by vscode as an argument on
activate.
Hello Vit, I have a few doubts about this approach.
- Planned to use storageUri as storagePath is deprecated
- These attributes are read-only and can be undefined when we open a file (not a workspace or a folder). COBOL LS works for a single file as well. So, ideally, the compile should also work.
And would need some refactoring for this. I plan to do it in a separate PR.
What's up with this RP? Do you need help to finish it?
Yes, I would need some help here. I am waiting for @VitGottwald to define the acceptance criteria.