buildship
buildship copied to clipboard
eclipse
[WIP] Composite Creation Implementation
Added most of the features to create a non functional workspace composite, including:
- Definition of composite via wizard and working set GUI
- Adding projects to the composite via wizard and properties
- Changing composite properties via properties menu
Import of external projects has yet to be implemented
Signed-off-by: kuzniarz [email protected]
I've fixed all the mentioned issues. The root project definition does not work properly right now but I will include a fix in the next commit!
I'll take a look soon. Sorry for the delay, once again I was dragged into another project.
No worries! I' ve just committed all changes along with the WIP GUI for the composite configuration.
@donat Any chance that this gets pushed forward by the Gradle team? We are currently stack now with Eclipse 2020-06 and Gradle 4.10.3.
Eclipse 2020-06 is the last one which allows Java 8 which is required by the Gradle STS Eclipse plugin (Java version determination problem). Gradle 4.10.3 is the last one which supports the Tool API version 3 required by the Gradle STS plugin.
Now we are desperately waiting for this PR to be pushed forward into a solution to get at Buildship the same functionality as Gradle STS has for composite builds.
We have done as far as we can to support this. Now some more Gradle internal know how is needed what we are lacking, unfortunately. Or, is there more we can do?
Ok, this is probably on me. I didn't receive a notification on the latest commits/comments. I cannot promise anything in terms of eta, but I'll take a look when I have some free time.
Next time don't hesitate to ping me sooner ;)
@donat Is there still some change request open? GitHub tells so. But I guess, it is outdated.
BTW, any progress achievable in the next time for this PR from your side?
@donat just a kindly remainder. 😃 Any progress to be expected here in the near future?
As much as it hurts to say this, but I don't have time to look into this in the near future. I might be able to look into this in my free time but I'm not working full time on this project at the moment and no work has been scheduled for me on the Eclipse front. I'm still doing maintenance and review PRs though, so community contributions will get merged.
Hi @donat, don't worry. That's (developer's) live. :smile:
Of course, we would appreciate any work from your side on this. But please, do not feel obligated. If you have any idea how we could support or push this forward from our side, reach out to us.
@donat Any chance to get guidance from the Gradle team here (not necessarily from you). I guess, "only" the integration/ connection with/to the Gradle Tools Provider API is left. All the GUI work is already done.
We could support further, but we would need some guidance... Maybe, you could discuss this in the Gradle team?
Hi! I'll get back to you on this soon. I'm in the process of planning some work in the IDE integration.
Hey @donat, any chance to push this forward? Can we in any way support further?
Hi @donat, this PR says, there are some change requests open. But I guess, @kuzniarz did all requested changes as he stated here.
Beside this, did you had any chance to put this PR on the roadmap?
Our offer is still valid...
Hi! I know I keep promising to look into this but given the size of the PR I seem to never find the time to deeply look into this. This changes now and here's what I think should happen. Let's get the PRs up-to-date with the latest main branch. I've updated this PR's base branch already. Please go ahead and rebase this PR as well. Also, the other thing I'd like to request is a feature description: please add description with screenshots on how this feature would work here. It will serve me as a "test plan" to evaluate the latest state. After manual testing, I'll come up with a list of what's missing before we can merge and release the feature (likely it will be stability, test coverage, documentation).
You can reach out to me via the Gradle Community Slack channel if you have any operational questions (you'll find an invite on the top of this page).
Good to hear, @donat! Let's push this forward.
@kuzniarz will start working on the description in the next week.
P.S. We are not allowed to access Slack from our corporate network. So, the discussion, if any, must take place here...
I think I resolved all conflicts successfully! I will add the feature description in your provided documentation and let you know then @donat Thanks for your work!
Okay, the build seems to fail, I need to look into that. Also something got messed up with signing off the commit. I suppose this is due to my system change and additionally a new email configured in github. I'll fix that on monday. Have a nice weekend guys!
Hi @donat ! Sorry for the late update, rebasing the project turned out to be a little more of a struggle than expected. I also realized, that you rebased the wrong branch! You have created a new, more recent branch in the past than the workspace-composite one. The branch is called 'kuzniarz-workspace-composites-rebased'!
Currently I reverted my local changes to the point before trying to merge/rebase it (before commit faafa91) and trying to rebase it to be as updated as the 'workspace-composite' branch, in terms of your changes.
My other option is to checkout the 'workspace-composite' branch and cherry-pick the changes from 'kuzniarz-workspace-composites-rebase' onto it. I'll let you know about the status till the end of the week.
Hi @donat, sorry for the long break as I did not have time to tackle this mess of a PR. Nonetheless, I finally managed. I have created a new pull request (#1297), as this one was not the correct branch with the most recent version. Alternatively I can cherrypick the changes from the other branch onto this one if thats your preferred way to handle the PR. If there is anything else to do with the commits, please let me know!
So one thing I can say right now is that the PR is unreviewable: it has 200+ commits and changes 1000+ files. However we proceed with this, we should have smaller steps.
Donát Csikós
Lead Software Engineer Gradle W. gradle.com
On Thu, Feb 8, 2024 at 2:52 PM Sebastian Kuzniarz @.***> wrote:
Hi @donat https://github.com/donat, sorry for the long break as I did not have time to tackle this mess of a PR. Nonetheless, I finally managed. I have created a new pull request (#1297 https://github.com/eclipse/buildship/pull/1297), as this one was not the correct branch with the most recent version. Alternatively I can cherrypick the changes from the other branch onto this one if thats your preferred way to handle the PR. If there is anything else to do with the commits, please let me know!
— Reply to this email directly, view it on GitHub https://github.com/eclipse/buildship/pull/988#issuecomment-1934167256, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADGQK7R7YK6TF4CHSKZ63LYSTKBNAVCNFSM4MQHIADKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJTGQYTMNZSGU3A . You are receiving this because you were mentioned.Message ID: @.***>
-- * CONFIDENTIALITY NOTICE*: The contents of this email message, and any attachments, are intended solely for the addressee(s) and may contain confidential, proprietary and/or privileged information legally protected from disclosure. If you are not the intended recipient of this communication, or if you received this communication by mistake, please notify the sender immediately and delete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, retransmission, dissemination, copying or storage of this message or its attachments is strictly prohibited.
@donat, the initial PR is now nearly 4 years old. No wonder, it is nonreviewable... 😄 ... We tried to keep up with the changes on the main branch.
However, due to that @kuzniarz has created a new PR #1297, see his last comment. Does your comment belongs to that PR too?
If not, we can close this PR and continue at #1297.
If yes, what is your recommendation how to proceed from there?
Hi! I did a bit of cleanup on Friday. The latest state is tracked on the kuzniarz-workspace-composites-rebased branch. It is based on the latest master and it has exactly two commits: the one introducing the no-op UI elements and another one with the prototype functionality. I haven't done any testing after I did the rebase so there's no guarantee that it works as intended. Can you please take a look?
Hi @donat! Thanks a lot for rebasing kuzniarz-workspace-composites-rebased! This should be the branch with the most recent changes that I have developed in the past! I will check if everything works as intended today and add some info to the Overview.md!
@donat So I was able to check the rebased version and most of it looks fine! I have to change a few minor details but I'm going to create a pull request with the needed changes as soon as thats done! Thanks again for the rebase!