buildship icon indicating copy to clipboard operation
buildship copied to clipboard

Dark theme support for Gradle syntax highlighting

Open vogella opened this issue 6 years ago • 4 comments

The current color for the Gradle syntax highlighting in the dark theme makes the text unreadable.

selection_303

Please fix, if you need help how to do this, please let me know.

vogella avatar Apr 05 '18 10:04 vogella

Looks like this is only a theme switch issue. After closing and re-opening the editor it looks better.

selection_305

Maybe you can add a preference listener for the color font switch and refresh the editor?

vogella avatar Apr 05 '18 11:04 vogella

That's correct, the editor only inherits the color scheme from the Java editor, but no preference listening is added. The fix sounds relatively easy. @vogella if you can provide a pr, that would be awesome ;)

donat avatar Apr 06 '18 08:04 donat

It is at the moment unlikely that I find time to contribute a fix, my current backlog in platform is already larger than my available time.

Donát Csikós [email protected] schrieb am Fr., 6. Apr. 2018, 10:11:

That's correct, the editor only inherits the color scheme from the Java editor, but no preference listening is added. The fix sounds relatively easy. @vogella https://github.com/vogella if you can provide a pr, that would be awesome ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse/buildship/issues/682#issuecomment-379181136, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIihvfqomxXnD_gHotGA47ExOcEAyHQks5tlyMdgaJpZM4TIOw1 .

vogella avatar Apr 06 '18 09:04 vogella

Hi,

Dark theme now suggest a change (via a button) in the Egradle editor preferences that works well with darkest theme.

JacquesLeRoux avatar Jan 14 '22 05:01 JacquesLeRoux