buildship icon indicating copy to clipboard operation
buildship copied to clipboard

Java Home warning tooltip not set in Advanced Option Settings

Open cypher256 opened this issue 2 years ago • 2 comments

org.eclipse.buildship.ui/src/main/java/org/eclipse/buildship/ui/internal/util/widget/AdvancedOptionsGroup.java Line 73

	this.builderFactory.newLabel(this).alignLeft().text(CoreMessages.Preference_Label_Gradle_User_Home);
	this.gradleUserHomeText = this.builderFactory.newText(this).alignFillHorizontal().control();
	this.gradleUserHomeBrowseButton = this.builderFactory.newButton(this).alignLeft().text(UiMessages.Button_Label_Browse).control();
	this.gradleUserHomeWarningLabel = this.builderFactory.newLabel(this).alignLeft().control();
	this.gradleUserHomeWarningLabel.setImage(PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_OBJS_WARN_TSK));
	HoverText.createAndAttach(this.gradleUserHomeWarningLabel, NLS.bind(CoreMessages.WarningMessage_Using_0_NonPortable, "Gradle user home"));

	this.builderFactory.newLabel(this).alignLeft().text(CoreMessages.Preference_Label_Java_Home);
	this.javaHomeText = this.builderFactory.newText(this).alignFillHorizontal().control();
	this.javaHomeBrowseButton = this.builderFactory.newButton(this).alignLeft().text(UiMessages.Button_Label_Browse).control();
	this.javaHomeWarningLabel = this.builderFactory.newLabel(this).alignLeft().control();
	this.javaHomeWarningLabel.setImage(PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_OBJS_WARN_TSK));
-	HoverText.createAndAttach(this.gradleUserHomeWarningLabel, NLS.bind(CoreMessages.WarningMessage_Using_0_NonPortable, "Java home")); // Line 73
+	HoverText.createAndAttach(this.javaHomeWarningLabel, NLS.bind(CoreMessages.WarningMessage_Using_0_NonPortable, "Java home"));

cypher256 avatar May 30 '22 03:05 cypher256

Can you please elaborate on the problem? What's the expected and actual behavior?

donat avatar May 31 '22 06:05 donat

Actual

  1. The hover message is "Java home" even though the target is Gradle user home. And Two hover messages overlap. a1
  2. When Java home is set, the hover message is not displayed. a2

Expected

  1. Hover message includes "Gradle user home". And one hover message.
  2. A hover message containing "Java home" appears.

cypher256 avatar Jun 01 '22 00:06 cypher256