birt icon indicating copy to clipboard operation
birt copied to clipboard

Add slash in Grid

Open sanshigongA opened this issue 3 years ago • 6 comments

like Excel

sanshigongA avatar Jun 10 '22 03:06 sanshigongA

Thanks for reporting and welcome. Can you be a bit more specific?

wimjongman avatar Jun 10 '22 06:06 wimjongman

Thanks your replay. We Chinese always use this style. For example,

sanshigongA avatar Jun 10 '22 06:06 sanshigongA

You can use any style, as long as you remain friendly and clear.

It is not clear what you want.

What do you mean by "add slash to grid like in excel"

wimjongman avatar Jun 10 '22 07:06 wimjongman

Hello Together, it seems for me that sanshigongA means the diagonal line on a table/grid cell, e.g.: slash-diagonal-line-at-cell

This is an option in Excel on border level. It would be a good improvement. I figured out "Stack Overflow" some solutions for HTML (CSS3 and svg) - https://stackoverflow.com/questions/28425574/slanted-diagonal-line-in-html-or-css (the example image is from there).

The improvement sounds simple but it seems to me a challange on BIRT-engine due to CSS3 / SVG-handling on emitters (Excel, PDF, ...) - my favorit would be CSS3-solution.

Have we perhaps an expert in our group on it?

speckyspooky avatar Jun 12 '22 09:06 speckyspooky

It seems like MS Word and MS Excel support this. It is a border property there.

I think there isn't a CSS standard for this. The accepted solution in https://stackoverflow.com/questions/28425574/slanted-diagonal-line-in-html-or-css with background-image and linear-gradient is working, but I think we cannot use it as-is, at there is a conflict with the existing background-image property.

So I think this cannot be support (reasonably) for the HTML emitter.

IMHO, for a solution we could add custom CSS border-properties like border-slash and border-backslash (?) just similar to border-top, eg border-slash-widthetc. These could fully be supported by PDF, Excel and Word emitters. For the HTML emitter, there would be some restrictions, the most important being that it doesn't work in conjunction with background-image. Of course, we'd need to add indivual code to the emitters to support this.

So, there'd be three tasks:

  1. Add a specification to the ROM model
  2. Document the restrictions
  3. Add emitter-specific implementations

I think it would be doable for someone with enough time.

hvbtup avatar Jun 13 '22 07:06 hvbtup

Hello Together, it seems for me that sanshigongA means the diagonal line on a table/grid cell, e.g.: slash-diagonal-line-at-cell

This is an option in Excel on border level. It would be a good improvement. I figured out "Stack Overflow" some solutions for HTML (CSS3 and svg) - https://stackoverflow.com/questions/28425574/slanted-diagonal-line-in-html-or-css (the example image is from there).

The improvement sounds simple but it seems to me a challange on BIRT-engine due to CSS3 / SVG-handling on emitters (Excel, PDF, ...) - my favorit would be CSS3-solution.

Have we perhaps an expert in our group on it?

year,that is my suggestion

sanshigongA avatar Jun 22 '22 03:06 sanshigongA

@wimjongman I have seens your new tag and I will take a look into it.

speckyspooky avatar Feb 10 '23 19:02 speckyspooky

Cheers!

wimjongman avatar Feb 10 '23 19:02 wimjongman

Short update: Currently I work on this topic and I have a alpha version based on my fork. I will start with extensive test to validate the stability and the try to figure out bugs.

speckyspooky avatar Feb 28 '23 21:02 speckyspooky

If you create a PR, please be sure to not mix the "background image topic" and the "slash in grid" topic.

hvbtup avatar Mar 03 '23 11:03 hvbtup

The pull request #1224 includes only the diagonal changes. My failure was at the beginning because I used my background-branch again. But the 62 files are only the new topic without any mix. Currently it seems to me that the Maven-Build has problems. But I cannot see the issue because there won't be logs written.

speckyspooky avatar Mar 03 '23 18:03 speckyspooky

The diagonal feature will be available with the BIRT-version 4.14

speckyspooky avatar Apr 15 '23 12:04 speckyspooky