zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

added default pki certs in case of empty config

Open amitsingh21 opened this issue 3 years ago • 2 comments

amitsingh21 avatar Apr 05 '22 14:04 amitsingh21

Hi @amitsingh21,

Thanks for your interest and contribution to Eclipse zenoh!

As you can see the eclipsefdn/eca check failed, meaning Eclipse didn't manage to verify your ECA signature wrt. your commits' email address.

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Contributor Agreement (ECA) and sign off on the Eclipse Foundation Certificate of Origin. For more information, please visit: http://wiki.eclipse.org/Development_Resources/Contributing_via_Git

JEnoch avatar Apr 05 '22 15:04 JEnoch

Also, our CI do a code format check. Please make sure to run cargo fmt before pushing to make it happy 😄

JEnoch avatar Apr 05 '22 15:04 JEnoch

Closing the issue this is has been addressed independently in #392 .

Mallets avatar Dec 15 '22 13:12 Mallets