zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

`ZBytes::chunks`

Open fuzzypixelz opened this issue 9 months ago • 5 comments

This function allows for splitting contiguous ZBytes into chunks without cloning the underlying buffer.

fuzzypixelz avatar Mar 20 '25 14:03 fuzzypixelz

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.46%. Comparing base (16ba77c) to head (edadf31). Report is 19 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
commons/zenoh-buffers/src/zbuf.rs 81.96% 11 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   70.92%   71.46%   +0.53%     
==========================================
  Files         360      363       +3     
  Lines       65175    66663    +1488     
==========================================
+ Hits        46225    47640    +1415     
- Misses      18950    19023      +73     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 20 '25 14:03 codecov[bot]

I'm not sure to understand the use case behind this PR. Can you elaborate?

Mallets avatar Mar 20 '25 16:03 Mallets

I'm not sure to understand the use case behind this PR. Can you elaborate?

I believe @OlivierHecart needed to "fragment" ZBytes in advanced pub/sub.

fuzzypixelz avatar Mar 21 '25 09:03 fuzzypixelz

Then I believe it should be implemented on a ZBuf leaving the ZSlice untouched.

Mallets avatar Mar 21 '25 09:03 Mallets

Then I believe it should be implemented on a ZBuf leaving the ZSlice untouched.

See 0c105227c.

fuzzypixelz avatar Mar 25 '25 15:03 fuzzypixelz