zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

Support for IPv6-only network interfaces

Open alexis-boisserand-acuity opened this issue 1 year ago • 1 comments

Substitutes the hardcoded Domain::IPV4 first parameter of some calls to Socket::new() by calls to Domain::for_address(), so that the domain is inferred from the address. This is necessary for network interfaces that are IPv6 only. I ran into this issue while trying to run zenoh over thread, which is an IPv6 only technology.

Thanks @alexis-boisserand-acuity for the PR! It LGTM, however we can't approve it and merge it until you sign the Eclipse Contribution Agreement. Please make sure you use the same email address you use on GitHub.

Mallets avatar Aug 27 '24 08:08 Mallets

@alexis-boisserand-acuity if you have issue to sign the ECA, another option to get your PR merged is that you state you are fine for us to include your changes in a PR we open.

Mallets avatar Aug 29 '24 09:08 Mallets

I've integrated your changes in https://github.com/eclipse-zenoh/zenoh/pull/1345. Once you have signed the ECA I can revert https://github.com/eclipse-zenoh/zenoh/pull/1345 and integrate this if needed.

Mallets avatar Sep 02 '24 08:09 Mallets

I was on vacation. Thanks for merging these changes in your PR.

Envoyé à partir de Outlook pour Androidhttps://aka.ms/AAb9ysg


From: Luca Cominardi @.> Sent: Monday, September 2, 2024 10:49:20 AM To: eclipse-zenoh/zenoh @.> Cc: Boisserand, Alexis @.>; Mention @.> Subject: Re: [eclipse-zenoh/zenoh] Support for IPv6-only network interfaces (PR #1322)

I've integrated your changes in #1345. Once you have signed the ECA I can revert #1345 and integrate this if needed. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

I've integrated your changes in #1345https://urldefense.com/v3/__https://github.com/eclipse-zenoh/zenoh/pull/1345__;!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0a-O7gHQI$. Once you have signed the ECA I can revert #1345https://urldefense.com/v3/__https://github.com/eclipse-zenoh/zenoh/pull/1345__;!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0a-O7gHQI$ and integrate this if needed.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/eclipse-zenoh/zenoh/pull/1322*issuecomment-2324175660__;Iw!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0a06SuXDw$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BC423XNOJ2NSZYLSCWWZFYDZUQRBBAVCNFSM6AAAAABNASZ2X2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGE3TKNRWGA__;!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0aLim98gU$. You are receiving this because you were mentioned.Message ID: @.***>

Thanks again for your contribution!

Mallets avatar Sep 03 '24 14:09 Mallets