zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

feat: unify pub/sub and query/reply modules

Open wyfo opened this issue 1 year ago • 6 comments

wyfo avatar Jun 26 '24 09:06 wyfo

@Mallets @kydos @milyin

wyfo avatar Jun 26 '24 09:06 wyfo

I've let the core module as is for now. Maybe we should create a qos module to put QOS related things (Priority and CongestionControl for now, but maybe more later), as they are common to pub/sub and query/reply.

wyfo avatar Jun 26 '24 09:06 wyfo

About Encoding, I'm hesitating to put it in core with Priority and CongestionControl, but it may also be put in bytes module, as this is closely related. I think I prefer this solution now.

wyfo avatar Jun 26 '24 09:06 wyfo

@wyfo it would be great if this PR comes with a battery of sister PRs to update all bindings/plugins/backends with the new module organization.

Mallets avatar Jun 27 '24 07:06 Mallets

This is incredibly long to patch all backend/plugins, so I've written a Python script to modify the imports automatically 😅

wyfo avatar Jun 28 '24 09:06 wyfo

@Mallets All the sister PRs have been opened.

wyfo avatar Jun 28 '24 13:06 wyfo