zenoh icon indicating copy to clipboard operation
zenoh copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-zenoh

fix: add the missing unstable feature

Open YuanYuYuan opened this issue 9 months ago • 2 comments

Closes #963. The change of feature flags only affects the dev-dependencies and is safe for the downstream dependencies/bindings.

YuanYuYuan avatar May 02 '24 08:05 YuanYuYuan

@Mallets can you please review this? Thanks.

YuanYuYuan avatar May 02 '24 09:05 YuanYuYuan

Self-reference in [dev-dependencies] created some problems in the past for release. @fuzzypixelz @OlivierHecart could you provide more insight on this?

Mallets avatar May 02 '24 12:05 Mallets

Self-reference in [dev-dependencies] created some problems in the past for release. @fuzzypixelz @OlivierHecart could you provide more insight on this?

This has been extensively discussed in https://github.com/rust-lang/cargo/issues/2911. @YuanYuYuan's workaround is standard procedure at this point. But it does introduce a cyclic dependency in the zenoh crate (to itself) which might break publishing: https://github.com/rust-lang/cargo/issues/4242. Apparently Cargo checks if dev dependencies are published upon publishing. I'll have to test this.

fuzzypixelz avatar May 28 '24 12:05 fuzzypixelz

I believe https://github.com/eclipse-zenoh/zenoh/pull/1131 solved this issue and it can be hence closed. @YuanYuYuan ?

Mallets avatar Jun 13 '24 13:06 Mallets

@Mallets, I've confirmed that the issue disappears after the fix. So let's close this PR.

YuanYuYuan avatar Jun 14 '24 03:06 YuanYuYuan