zenoh-python icon indicating copy to clipboard operation
zenoh-python copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-zenoh

Scorched earth 2

Open wyfo opened this issue 1 year ago • 5 comments

Complete rewriting using only Rust code (and Python stub)

wyfo avatar Apr 18 '24 11:04 wyfo

@evshary I've updated the years because it has been rewritten from scratch, so I think it's pertinent.

wyfo avatar Apr 22 '24 08:04 wyfo

The doc rendition is not good, because it doesn't seem to take in account the change that I made in .readthedocs.yml. I've tested it on my side, and it works fine.

wyfo avatar Apr 25 '24 14:04 wyfo

Tests doesn't pass because it seems I've resolved a bug, which was taken in account in the tests. In fact, some tests was not able to be stopped with SIGINT, and required to be killed. ~~It's no more the case with this PR~It's still the case with this PR. I've spent one hour trying to determine what was the cause of this bug on main, but I'm ashamed to admit I failed; I don't know what is causing this kind of deadlocks in the tests. Anyway, I should update the tests to not expect programs to be killed. @evshary If you have information about this, I would be very interested.

wyfo avatar Apr 25 '24 15:04 wyfo

The tests doesn't pass yet because of the deadlock issue in the examples. It's caused by relying on pseudo-RAII while exiting tests with an exception, which causes finalizers to run while Python interpreter is shutting down. Solving this issue requires an important discussion about RAII use, so for now, the tests aren't touched.

wyfo avatar May 06 '24 08:05 wyfo

@wyfo Please change the base branch to dev/1.0.0 as protocol_changes is no longer the development branch.

fuzzypixelz avatar May 17 '24 10:05 fuzzypixelz