remove constructor of `z_entty_global_id_t` and it's fields access

Open milyin opened this issue 1 year ago • 3 comments

Describe the release item

In the existing Rust API the EntityGlobalId is a wrapper fo EntityGlobalIdProto. All details of EntityGlobalIdProto is hidden now. So functions z_entity_global_id_new, z_entity_global_id_zid, z_entity_global_id_eid should also be removed from C API

Jun 28 '24 08:06 milyin

@Mallets please confirm, that now EntityGlobalId is blind and user should not neither be able to create it manually nor have access to (SessionId, EntityId) fields @wyfo, thank you for noticing this issue in zenoh-c API

Jun 28 '24 08:06 milyin

EntityGlobalId is internal and users should only have read access to it. In any case, EntityGlobalId should only be present in SourcInfo which is unstable if I'm not mistaken.

Jun 28 '24 08:06 Mallets

Should be fixed in https://github.com/eclipse-zenoh/zenoh-c/pull/485

Jun 28 '24 10:06 milyin

Rust's EntityGlobalId provides RO access to zid and eid fields. Constructor is removed. So C API is ok,

Aug 04 '24 12:08 milyin