wakaama icon indicating copy to clipboard operation
wakaama copied to clipboard

tinydtls: Update to most recent version, simplify usage

Open rettichschnidi opened this issue 3 years ago • 13 comments

While (again) not an official release, this will advance us by 205 commits:

$ git rev-list --count 178b945e5497b813b1239e2fbf57e34b7488745f..HEAD
205

Smoke tested like this:

$ examples/client/lwm2mclient_tinydtls -h leshan.eclipseprojects.io -4 -p 5784 -n wakaama-560-with-dtls -i wakaama-560-with-dtls -s 5cdafa07cf5d7e0e65b8e504bc0dc9 -b 
Trying to bind LWM2M Client to port 56830
LWM2M Client "wakaama-560-with-dtls" started on port 56830
>  -> State: STATE_BOOTSTRAPPING
 -> State: STATE_BOOTSTRAPPING
60 bytes received from [23.97.187.154]:5784
16 FE FD 00  00 00 00 00  00 00 00 00  2F 03 00 00   ............/...
23 00 00 00  00 00 00 00  23 FE FD 20  5F EB 78 AC   #.......#.. _.x.
27 DC F7 3F  37 DF 7B 94  7D A2 A4 71  F9 85 A8 20   '..?7.{.}..q... 
1E 41 62 7A  14 69 2F C3  1F 1D 27 76                .Abz.i/...'v
 -> State: STATE_BOOTSTRAPPING
126 bytes received from [23.97.187.154]:5784
16 FE FD 00  00 00 00 00  00 00 01 00  58 02 00 00   ............X...
4C 00 01 00  00 00 00 00  4C FE FD 62  01 77 D9 69   L.......L..b.w.i
E1 A0 C3 8C  F8 03 AD AA  71 FC A4 19  8B 29 A4 21   ........q....).!
47 00 85 0F  6D 3A 7F A4  C2 54 23 20  D6 9D 3A A4   G...m:...T# ..:.
68 40 59 50  3C D7 46 F0  39 2B 69 71  C1 4A 70 FE   h@YP<.F.9+iq.Jp.
35 C7 57 55  5D 03 B1 41  35 D9 84 93  C0 A8 00 00   5.WU]..A5.......
04 00 17 00  00 16 FE FD  00 00 00 00  00 00 00 02   ................
00 0C 0E 00  00 00 00 02  00 00 00 00  00 00         ..............
 -> State: STATE_BOOTSTRAPPING
67 bytes received from [23.97.187.154]:5784
14 FE FD 00  00 00 00 00  00 00 03 00  01 01 16 FE   ................
FD 00 01 00  00 00 00 00  00 00 28 00  01 00 00 00   ..........(.....
00 00 00 6F  CD 0A D7 5F  9F C1 10 A4  6C 49 DD 9B   ...o..._....lI..
44 A5 93 29  86 CE F5 84  B2 39 86 09  28 92 94 B3   D..).....9..(...
AD 3C 54                                             .<T
 -> State: STATE_BOOTSTRAPPING
 -> State: STATE_BOOTSTRAPPING
37 bytes received from [23.97.187.154]:5784
17 FE FD 00  01 00 00 00  00 00 01 00  18 00 01 00   ................
00 00 00 00  01 AB 55 13  E6 D1 C9 D5  19 F1 0F 23   ......U........#
E3 82 33 35  A6                                      ..35.
 -> State: STATE_BOOTSTRAPPING
43 bytes received from [23.97.187.154]:5784
17 FE FD 00  01 00 00 00  00 00 02 00  1E 00 01 00   ................
00 00 00 00  02 01 E1 29  15 0A AE CC  4F 99 9E 2B   .......)....O..+
A2 42 7F 0D  55 A6 F3 4D  C5 4B 12                   .B..U..M.K.
 -> State: STATE_BOOTSTRAPPING
43 bytes received from [23.97.187.154]:5784
17 FE FD 00  01 00 00 00  00 00 03 00  1E 00 01 00   ................
00 00 00 00  03 5F 49 13  B0 39 CC 12  D9 29 B0 25   ....._I..9...).%
E5 9E B9 C0  25 38 81 38  7A B6 E9                   ....%8.8z..
 -> State: STATE_BOOTSTRAPPING
331 bytes received from [23.97.187.154]:5784
17 FE FD 00  01 00 00 00  00 00 04 01  3E 00 01 00   ............>...
00 00 00 00  04 B4 05 9B  A6 EB C7 79  B9 C5 F8 92   ...........y....
ED BD A1 F2  88 F1 B0 94  92 9F DF E6  6A 25 D9 EC   ............j%..
44 72 B8 26  09 68 7C A9  9A 4B 65 46  41 42 1B 19   Dr.&.h|..KeFAB..
23 D4 48 8B  CD F3 99 AB  98 03 D7 32  DD FA C1 F5   #.H........2....
F2 4F ED F8  EF AF F9 7C  E6 26 B0 F6  35 E6 67 BB   .O.....|.&..5.g.
29 8F 9C ED  CB 92 83 A9  EB 2D A2 49  E8 97 81 AC   )........-.I....
A8 B2 3B 61  D8 34 95 77  60 76 2B 62  47 AF 98 7E   ..;a.4.w`v+bG..~
25 81 84 57  C4 1F 67 C6  33 35 7D 8A  0A A4 23 68   %..W..g.35}...#h
B4 BB 96 57  64 51 B6 32  E1 9D 9E 3B  0B 2D E7 A9   ...WdQ.2...;.-..
1A 68 8C 69  67 1B C2 43  AE F1 81 73  FC FF 1C 80   .h.ig..C...s....
20 F2 08 81  A1 28 E7 DE  82 98 66 D4  38 B6 8D 7A    ....(....f.8..z
E4 FC 29 AA  D5 13 20 5A  BA F8 60 6E  56 02 6D 42   ..)... Z..`nV.mB
76 A1 D1 C2  FB CA FE 9B  AD F6 CE 7A  03 08 59 FE   v..........z..Y.
EC 2E 2B 80  9F 51 CD 4C  14 97 2D 49  CD 48 99 48   ..+..Q.L..-I.H.H
7A AB 1B 67  94 C9 22 A3  54 58 EB 8B  9C D8 76 40   z..g..".TX....v@
65 1B 91 F4  B1 25 5A A3  71 2F 52 3A  2B D9 62 3C   e....%Z.q/R:+.b<
4F 4B E7 A1  A9 84 FF AE  C5 3A E5 73  05 FF 1D 96   OK.......:.s....
7A 0A 8A 12  89 53 0C DA  52 9F D8 6C  F6 04 89 FD   z....S..R..l....
77 A1 06 BA  EE 48 B5 A2  8B 18 58 37  B4 EE 1A 9E   w....H....X7....
12 1D A1 95  90 86 4F 82  F5 CA 66                   ......O...f
 -> State: STATE_BOOTSTRAPPING
153 bytes received from [23.97.187.154]:5784
17 FE FD 00  01 00 00 00  00 00 05 00  8C 00 01 00   ................
00 00 00 00  05 F7 90 4B  56 43 61 AB  20 B4 60 0C   .......KVCa. .`.
68 C1 D8 C0  D5 93 AB 34  CA 51 CB 93  A3 D5 70 B8   h......4.Q....p.
2B 51 AC E5  D9 C8 56 B8  40 62 EE 38  3E E8 DE 01   [email protected]>...
0C 2B F2 30  D0 A2 58 5D  F1 42 19 19  0E FF 00 0A   .+.0..X].B......
73 A9 2C DB  D5 5B B1 70  F3 93 4E 2E  02 8F 7C B0   s.,..[.p..N...|.
18 13 5E 22  C8 53 BA 69  39 40 BF 52  52 ED 90 7C   ..^"[email protected]..|
04 5A 04 F8  11 66 A6 E6  DF E3 8A CF  99 19 66 35   .Z...f........f5
83 3D 1D E3  04 4A 2D B2  C4 C7 E5 33  B9 A5 A7 67   .=...J-....3...g
C1 1B 0C 79  A4 18 69 0B  C8                         ...y..i..
 -> State: STATE_BOOTSTRAPPING
44 bytes received from [23.97.187.154]:5784
17 FE FD 00  01 00 00 00  00 00 06 00  1F 00 01 00   ................
00 00 00 00  06 21 53 B5  0D 74 6E 30  36 4A 2E 03   .....!S..tn06J..
79 30 0D CB  DA 29 AF 0C  2D 1E 1B 7D                y0...)..-..}
 -> State: STATE_BOOTSTRAPPING
 -> State: STATE_REGISTERING
22 bytes received from [23.97.187.154]:5683
64 41 F3 0D  0D F3 DB 77  82 72 64 0A  64 69 4E 61   dA.....w.rd.diNa
34 51 32 48  79 4F                                   4Q2HyO
 -> State: STATE_READY


>  -> State: STATE_READY
quit

non IPV4 or IPV6 address
non IPV4 or IPV6 address

(This should be merged after #658)

rettichschnidi avatar Feb 06 '22 13:02 rettichschnidi

Do we need a new CQ for this, the existing one is for version 0.8.2

tuve avatar Feb 08 '22 07:02 tuve

Do we need a new CQ for this, the existing one is for version 0.8.2

You are talking about tinydtls dependency right ?

As now tinydtls is an eclipse project, AFAIK no CQ is needed.

You could ask why does it exist a CQ for the version 0.8.2 ? Good question, I guess probably before tinydtls become an eclipse project :thinking:

sbernard31 avatar Feb 08 '22 08:02 sbernard31

Just to mention: tinyDtls made a lot of progress and is still making progress. If you're interested, for testing the "develop" branch contains many bugfixes of the last months and there are still improvement and bugfixes pending. So I would recommend, to check frequently, if that works for you.

boaks avatar Feb 08 '22 08:02 boaks

@boaks do you know the idea behind master and develop branch ? I'm not sure to get the development process ? (or maybe @obgm could answer about it ?) Let me know if I should rather ask this at https://github.com/eclipse/tinydtls/issues)

sbernard31 avatar Feb 08 '22 08:02 sbernard31

I don't know. So asking @obgm is the best.

boaks avatar Feb 08 '22 09:02 boaks

The reason for these branches is that it follows the usual best practices for git workflows with a stable main branch, and a develop branch where the next stable version is being prepared. The odd thing for tinydtls is that there is not really a stable version as it has never been released while under the hood of Eclipse Foundation; The current main branch reflects the initial contribution and will be updated once the 1.0 release process has finished.

obgm avatar Feb 08 '22 09:02 obgm

Thanks to @boaks I think we are getting closer to this initial release within the next weeks.

obgm avatar Feb 08 '22 09:02 obgm

Thanks to @boaks I think we are getting closer to this initial release within the next weeks.

Would you (tinydtls) prefer Wakaama to update now (and again in a few weeks) or wait for the final release?

rettichschnidi avatar Feb 08 '22 09:02 rettichschnidi

+1 for the final release

tuve avatar Feb 08 '22 09:02 tuve

Would you (tinydtls) prefer Wakaama to update now (and again in a few weeks) or wait for the final release?

That depends on what you want. I usually try the "newest", but with care, mainly in order to find left or new bugs. FMPOV, the current "develop" is worth to be used, even if some issues are open. I guess, in some weeks, it will be worth again to update. Don't forget to report issues, if you get faced ones.

boaks avatar Feb 08 '22 09:02 boaks

I suppose updating now is a good idea, especially as the release process will take some time. We could provide a new release candidate soon if you prefer to have some synchronization point.

obgm avatar Feb 08 '22 09:02 obgm

@obgm, I think I get it, you're master branch is a kind of maintenance branch.

Currently tinydtls is just used for example / demo, right ? IMHO a Wakaama release should ideally use a released version of tinydtls but during development phase, this could OK to use a development branch. (especially if this is just for demo)

E.g. Leshan (LWM2M in java) development branch (master) frequently depends on development version of Scandium (DTLS in java). It allows to provide feedback or detect bugs sooner. The only constraint is that you need to ensure that the library you depend on will release in an acceptable time for you.

sbernard31 avatar Feb 08 '22 09:02 sbernard31

Currently tinydtls is just used for example / demo, right ?

Yes, its works-with.

side note: I intend to include the DTLS enabled client binary in the integration testing, but even then, tinydtls will not be a dependency of the Wakaama library itself.

rettichschnidi avatar Feb 08 '22 10:02 rettichschnidi

Just updated this PR on the most recent Wakaama master and with the most recent commit of tindydtls (there is no release yet). Suggesting to merge this PR in this current state.

rettichschnidi avatar Feb 24 '23 15:02 rettichschnidi

I consider, that when the PR for RFC5746 is merged into tinydtls/main, a update would make again sense. I will ping, when we merged it.

boaks avatar Feb 26 '23 08:02 boaks

Just realized the thumbs up from @boaks. I consider this an approval and therefore merge this PR. :dancers:

rettichschnidi avatar Mar 01 '23 08:03 rettichschnidi