vertx-sql-client icon indicating copy to clipboard operation
vertx-sql-client copied to clipboard

Upgrade to Testcontainers 1.15.1 and use prebuilt image for DB2

Open aguibert opened this issue 5 years ago • 5 comments

  • Upgrade to Testcontainers 1.15.1, mainly because it contains a fix needed to use Testcontainers on Mac OS
  • Use prebuilt image for DB2 so we can avoid using a file system mount (not supported on some OSes)

aguibert avatar Dec 16 '20 21:12 aguibert

@vietj please review if you can

aguibert avatar Dec 16 '20 21:12 aguibert

@aguibert FYI you could also use withClasspathResourceMapping, it uses the copy strategy instead of a volume mapping which works reliably on any system :)

bsideup avatar Dec 17 '20 01:12 bsideup

@vietj I did not. It's been about a year since I filed my last CQ. Can you please remind me of the process?

aguibert avatar Dec 17 '20 14:12 aguibert

I also support this pull request because it fixes https://github.com/testcontainers/testcontainers-java/pull/2605 that affects me and the fix ships with testcontainers >= 1.14.2.

julianladisch avatar Feb 12 '21 15:02 julianladisch

I'll file the CQ

On Fri, Feb 12, 2021 at 4:57 PM julianladisch [email protected] wrote:

I also support this pull request because it fixes testcontainers/testcontainers-java#2605 https://github.com/testcontainers/testcontainers-java/pull/2605 that affects me and the fix ships with testcontainers >= 1.14.2 https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.2 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse-vertx/vertx-sql-client/pull/858#issuecomment-778279236, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCVA5UY7QEYLQ32HCGLS6VFWTANCNFSM4U6ULECQ .

vietj avatar Feb 12 '21 16:02 vietj