vertx-sql-client icon indicating copy to clipboard operation
vertx-sql-client copied to clipboard

Coerce row values to string for Row#getString

Open aguibert opened this issue 4 years ago • 4 comments

Fixes a confusing scenario that a user reported here: https://github.com/quarkusio/quarkus/issues/11035

aguibert avatar Sep 26 '20 03:09 aguibert

I am not sure this is something we want to do for free

vietj avatar Sep 27 '20 09:09 vietj

my point is that people should know the type of the row they are retrieving and they should use the correct getter otherwise they should use getValue().toString() instead

vietj avatar Sep 27 '20 09:09 vietj

I agree with Julien. The javadoc should be extended to make this clear: #802

julianladisch avatar Nov 20 '20 18:11 julianladisch

getValue().toString() may cause NPE. Should we add getValueAsString that returns null for null and toString() otherwise?

julianladisch avatar Nov 20 '20 18:11 julianladisch