vertx-sql-client icon indicating copy to clipboard operation
vertx-sql-client copied to clipboard

PgSubscriberImpl silently does not register exception handler

Open andreas-eberle opened this issue 6 months ago • 1 comments

Problem

When you try to regiser an exception handler in PgSubscriberImpl, the handler is never registered. See https://github.com/eclipse-vertx/vertx-sql-client/blob/master/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/pubsub/PgSubscriberImpl.java#L273

There is also no UnsupportedOperationException or any log to make the caller aware that this method is not doing anything right now. This is dangerous, because you think you have registered an exception handler, but in fact you have not and you will never be able to handle exceptions this way.

Version

master

andreas-eberle avatar Feb 02 '24 09:02 andreas-eberle

Actually I think exception handler in this case would not report anything useful, as this is a subscription and the class itself only relay notifications. What do you have in mind ?

vietj avatar Feb 02 '24 13:02 vietj