vertx-sql-client icon indicating copy to clipboard operation
vertx-sql-client copied to clipboard

Fail with exception on timeout while waiting for connection pool

Open dennisschroer opened this issue 1 year ago • 1 comments

Motivation:

When a timeout occurs while waiting for a new connection, the future fails with a simple "Timeout" message without a stack trace. This makes it very difficult to debug where in the application the error occurs. We have a longer running process with multiple requests to the database, and having a stacktrace would help us.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

dennisschroer avatar Jul 31 '23 13:07 dennisschroer

can you reproduce this case with a test ? it is not clear how it happens.

I would like this behaviour to be tested and the only case it can happen is when the connection pool is too busy to respond (which shall not happen unless it is blocked) or when there is a race with the acquisition (basically cancel succeeds and returns false, it was not able to cancel because the handler got satisfied which makes the connection borrower progress).

also this callback cannot fail, it is always completed with a succeeded future, unless the pool is closed

vietj avatar Aug 30 '23 08:08 vietj