vertx-sql-client icon indicating copy to clipboard operation
vertx-sql-client copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-vertx

A wrong link in javadoc

Open azurvii opened this issue 2 years ago • 2 comments

https://github.com/eclipse-vertx/vertx-sql-client/blob/17719e5db4d305ebeb5f0feac40b11277f0bcd90/vertx-sql-client/src/main/java/io/vertx/sqlclient/Pool.java#L186

Should be withConnection, not withTransaction.

azurvii avatar Jun 23 '22 09:06 azurvii

can you provide a PR ?

On Thu, Jun 23, 2022 at 11:59 AM azurvii @.***> wrote:

https://github.com/eclipse-vertx/vertx-sql-client/blob/17719e5db4d305ebeb5f0feac40b11277f0bcd90/vertx-sql-client/src/main/java/io/vertx/sqlclient/Pool.java#L186

Should be withConnection, not withTransaction.

— Reply to this email directly, view it on GitHub https://github.com/eclipse-vertx/vertx-sql-client/issues/1206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCXAEXIAGD65YQC2BVDVQQYPNANCNFSM5ZTX7JUQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

vietj avatar Jun 23 '22 12:06 vietj

Sorry, I can't sign the Eclipse agreement with my github commit email. It'd be great if you can help with the change. Thanks!

azurvii avatar Jun 23 '22 14:06 azurvii