vertx-codegen icon indicating copy to clipboard operation
vertx-codegen copied to clipboard

Missing method in VertxOptions

Open codepitbull opened this issue 6 years ago • 4 comments

I issue was opened against vertx-lang-scala about a missing mthod (https://github.com/vert-x3/vertx-lang-scala/issues/63). After some research I can confirm that clusterManager isn't part of the 'properties' list provided when generating code for DataObjects. This is the method in VertxOptions:

public VertxOptions setClusterManager(ClusterManager clusterManager) { this.clusterManager = clusterManager; return this; }

codepitbull avatar Feb 02 '18 22:02 codepitbull

that's not really possible at the moment as data object methods only denotes vertxgen types - we may improve that in the future to open it to any type and have the shim to chose wether or not to expose these types

vietj avatar Feb 03 '18 07:02 vietj

How about simply providing all NOT @VertxGen-annotated methods that are part of a public Vertx-API (so not impl-methods) as a separate collection? Right now I have to manually handle them by adding specific handling in the templates. Getting a list of them would allow me to either log their existence or define some generic handling, in my case I'd simply pass them through as is without converting them.

codepitbull avatar Feb 07 '18 09:02 codepitbull

yes, we should do that, I've added a section in my slides for the F2F meemting about it

it should also work for vertxgen types

vietj avatar Feb 07 '18 10:02 vietj

Yes I believe that would be nice for groovy and ECMAScript too

pmlopes avatar Mar 03 '18 18:03 pmlopes