vert.x icon indicating copy to clipboard operation
vert.x copied to clipboard
verified publisher icon eclipse-vertx

Implement support for DNS over TCP fallback in Netty.

Open azotcsit opened this issue 8 months ago • 4 comments

This PR resolves https://github.com/eclipse-vertx/vert.x/issues/4493. The high-level idea is to support Netty feature to retry failed UDP DNS queries via TCP - https://github.com/netty/netty/issues/9127.

I'm not sure about master branch, do I need to raise a separate PR for that?

azotcsit avatar Apr 17 '25 14:04 azotcsit

Hi @vietj,

I'd be very grateful if you could take a look at this PR and guide me on the next steps. I'm new to Vert.x contribution process, so any suggestions would be very welcomed.

Thanks!

azotcsit avatar Apr 17 '25 14:04 azotcsit

can you test this new option ?

vietj avatar Apr 17 '25 17:04 vietj

@vietj Thanks for the prompt reply. Are you talking about manual testing or about writing unit tests?

I think I can test it manually, however it will take some time as the problem is not easily reproducible in our env. WRT unit testing, I'm not sure how to validate that TCP fallback happened. Could you please give me some references / suggestions on the best way to implement that?

azotcsit avatar Apr 18 '25 17:04 azotcsit

we could need to mock the TCP server and respond to the same traffic that a server does

vietj avatar May 06 '25 13:05 vietj