vert.x icon indicating copy to clipboard operation
vert.x copied to clipboard

Optimize Http 2 header validation

Open franz1981 opened this issue 1 year ago • 0 comments

While inspecting few benchmark this behaviour popup in the HTTP 2 server response handling: image

It shows that we do perform few validations around header names, which could be improved or merged (if proves to be beneficial, in the common case things are right).

The existing process work like this;

for header names:

  • vertx validate against no ctrl char presence and no ASCII chars via https://github.com/eclipse-vertx/vert.x/blob/67ba7136b486fef8d22699c6fc366d80bf6eb6fa/src/main/java/io/vertx/core/http/impl/HttpUtils.java#L907
  • vertx convert to lower case (checking for upper case chars) via https://github.com/eclipse-vertx/vert.x/blob/67ba7136b486fef8d22699c6fc366d80bf6eb6fa/src/main/java/io/vertx/core/http/impl/HttpUtils.java#L708
  • netty validate against upper case chars (which sounds useless here, given that we always send lowercase ones!) and known pseudo-headers, if present, via https://github.com/netty/netty/blob/b1947417b7444326965086b951b75f0128cf7085/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java#L44

for header values:

  • vertx validate the value chars with a state machine at https://github.com/eclipse-vertx/vert.x/blob/67ba7136b486fef8d22699c6fc366d80bf6eb6fa/src/main/java/io/vertx/core/http/impl/HttpUtils.java#L805
  • netty doesn't validate the header value (!?), and point to https://github.com/netty/netty/blob/b1947417b7444326965086b951b75f0128cf7085/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java#L177-L183

Additionally, related header names, the RFC report at https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2

Just as in HTTP/1.x, header field names are strings of ASCII characters that are compared in a case-insensitive fashion. However, header field names MUST be converted to lowercase prior to their encoding in HTTP/2. A request or response containing uppercase header field names MUST be treated as malformed

which means that the vertx validation against control character is just too much, and could be dropped.

Re header values, instead, it seems that the validation should follow https://datatracker.ietf.org/doc/html/rfc7230#section-3.2 (which I have yet to interpret).

franz1981 avatar Jan 17 '24 14:01 franz1981