vert.x
vert.x copied to clipboard
Favour inlining on http header value validation and specialize it per sequence type
This is addressing a small (relative) regression on header validation due to the improvement on Netty side. The previous comparison with Netty was at https://github.com/eclipse-vertx/vert.x/pull/4590#issuecomment-1385021782
Before:
Benchmark (asciiNames) (validate) Mode Cnt Score Error Units
HeadersSetBenchmark.vertxSmall true true thrpt 20 3522.025 ± 42.544 ops/ms
HeadersSetBenchmark.vertxSmall false true thrpt 20 2709.417 ± 138.243 ops/ms
This PR:
Benchmark (asciiNames) (validate) Mode Cnt Score Error Units
HeadersSetBenchmark.vertxSmall true true thrpt 20 5247.075 ± 86.684 ops/ms
HeadersSetBenchmark.vertxSmall false true thrpt 20 3575.735 ± 80.029 ops/ms
With this patch we're now back near to Netty validation (that's less complex then our)
we need a test for this
Yep, let me add it :)
missing test :-)