vert.x icon indicating copy to clipboard operation
vert.x copied to clipboard

New parser for length field based protocols

Open EmadAlblueshi opened this issue 4 years ago • 8 comments

Signed-off-by: Emad Alblueshi [email protected]

Motivation:

A new LengthFieldParser that handles length field based protocols it uses the RecordParser internally with simple API it supports the following :

  1. Length fields byte(1), short(2), medium(3), int(4) and long(8).
  2. Maximum frame length the default is Integer.MAX_VALUE and can be changed explicitly.
  3. Length field offset to skip explicit length while parsing.

It's rewritten instead of https://github.com/eclipse-vertx/vert.x/pull/3742 as @vietj and @tsegismont suggested in vertx-dev google group.

Thanks!

EmadAlblueshi avatar Jan 12 '21 23:01 EmadAlblueshi

@tsegismont ping :-)

EmadAlblueshi avatar Jan 28 '21 12:01 EmadAlblueshi

Hi @EmadAlblueshi , thanks for the updates. I was able to take another look today.

Can you update the very long test? I must admit I'm not prepared to review it. It seems many tests share the same code. Perhaps it can be factored out?

I will try my best to refactor it.

EmadAlblueshi avatar Feb 03 '21 18:02 EmadAlblueshi

Thank you Emad

tsegismont avatar Feb 04 '21 14:02 tsegismont

@EmadAlblueshi bro,release it,come on!!! @vietj @tsegismont

July-X avatar Jun 09 '22 03:06 July-X

It seems all test passed, so when will it be released?

moxi-born avatar May 08 '23 14:05 moxi-born

Hi @moxi-born @July-X Sorry for long time I was busy in my new job!

Hi @tsegismont as far as I remember you told me that the test code was so long and needs to be refactored. do you have any recommendations?

EmadAlblueshi avatar May 08 '23 14:05 EmadAlblueshi

@EmadAlblueshi I'll come back to this after 4.4.2 is released

tsegismont avatar May 10 '23 12:05 tsegismont

@tsegismont Sure thanks 👍🏻

EmadAlblueshi avatar May 10 '23 13:05 EmadAlblueshi