vert.x
vert.x copied to clipboard
New parser for length field based protocols
Signed-off-by: Emad Alblueshi [email protected]
Motivation:
A new LengthFieldParser
that handles length field based protocols it uses the RecordParser
internally with simple API it supports the following :
- Length fields
byte(1)
,short(2)
,medium(3)
,int(4)
andlong(8)
. - Maximum frame length the default is
Integer.MAX_VALUE
and can be changed explicitly. - Length field offset to skip explicit length while parsing.
It's rewritten instead of https://github.com/eclipse-vertx/vert.x/pull/3742 as @vietj and @tsegismont suggested in vertx-dev google group.
Thanks!
@tsegismont ping :-)
Hi @EmadAlblueshi , thanks for the updates. I was able to take another look today.
Can you update the very long test? I must admit I'm not prepared to review it. It seems many tests share the same code. Perhaps it can be factored out?
I will try my best to refactor it.
Thank you Emad
@EmadAlblueshi bro,release it,come on!!! @vietj @tsegismont
It seems all test passed, so when will it be released?
Hi @moxi-born @July-X Sorry for long time I was busy in my new job!
Hi @tsegismont as far as I remember you told me that the test code was so long and needs to be refactored. do you have any recommendations?
@EmadAlblueshi I'll come back to this after 4.4.2 is released
@tsegismont Sure thanks 👍🏻