tycho icon indicating copy to clipboard operation
tycho copied to clipboard

Remove org.eclipse.tycho.core.osgitools.targetplatform.LocalDependencyResolver

Open laeubi opened this issue 2 years ago • 2 comments

currently there is a "p2" resolver and a "local" resolver.

The local resolver uses deprecated code, and is only used for -Dtycho.targetPlatform described as:

tycho.targetPlatform is deprecated and WILL be removed in the next Tycho version.

laeubi avatar Jan 03 '22 16:01 laeubi

Ad this tycho.targetPlatform has been marked as deprecated for removal for a long time, it's fine to remove it ASAP without waiting for a new major.

mickaelistria avatar Jan 07 '22 10:01 mickaelistria

The problem is that

AbstractTychoMojoTestCase#getSortedProjects(File basedir, Properties userProperties, File platform)

actually still using this property:

[ERROR]   DependencyComputerTest.testStrictBootClasspathAccessRules:141->AbstractTychoMojoTestCase.getSortedProjects:142 » CompoundRuntime
[ERROR]   MavenDependencyCollectorTest.testNestedJars:37->AbstractTychoMojoTestCase.getSortedProjects:125->AbstractTychoMojoTestCase.getSortedProjects:142 » CompoundRuntime
[ERROR]   TychoTest.testBundleExtraClasspath:197->AbstractTychoMojoTestCase.getSortedProjects:125->AbstractTychoMojoTestCase.getSortedProjects:142 » CompoundRuntime
[ERROR]   TychoTest.testMNGECLIPSE942:162->AbstractTychoMojoTestCase.getSortedProjects:125->AbstractTychoMojoTestCase.getSortedProjects:142 » CompoundRuntime
[ERROR]   TychoTest.testMissingClasspathEntries:174->AbstractTychoMojoTestCase.getSortedProjects:125->AbstractTychoMojoTestCase.getSortedProjects:142 » CompoundRuntime
[ERROR]   TychoTest.testProjectPriority:107->AbstractTychoMojoTestCase.getSortedProjects:125->AbstractTychoMojoTestCase.getSortedProjects:142 » CompoundRuntime

laeubi avatar Jan 11 '22 14:01 laeubi