WIP De-plexus Tycho
Applied https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup
Changes:
- removed ol' Plexus
- and related classes like Logger, Disposable, etc
- using ctor injection, not field/plexus injection
Is WIP and will fail, build is OK up to OSGi compiler plugin subproject currently.
Test Results
603 files ± 0 4 errors 599 suites - 4 3h 25m 52s :stopwatch: - 58m 14s 415 tests - 15 144 :white_check_mark: - 278 7 :zzz: ±0 3 :x: + 2 261 :fire: +261 1 200 runs - 90 425 :white_check_mark: - 842 21 :zzz: - 1 11 :x: +10 743 :fire: +743
For more details on these parsing errors, failures and errors, see this check.
Results for commit 924293d1. ± Comparison against base commit 6c80860d.
This pull request removes 23 and adds 8 tests. Note that renamed tests count towards both.
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ testProductBuildForJava11
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ testProductBuildForJava17
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ testP2ResolutionWithLowerBREEThanRequiredBundle
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ testRepositoryAggregationForJava7
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testCategoryUnitHasInclusionsVersionsExpanded
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testFeatureUnitHasOwnVersionAndInclusionsExpanded
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testIncludedExternalArtifactIsAssembled
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testIncludedReactorArtifactsAreAssembled
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testProductUnitHasOwnVersionAndInclusionsExpanded
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testPublishedBundleIU
…
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.TransitiveP2RepoTest ‑ Unknown test
org.eclipse.tycho.test.packaging.ConsumerPomTest ‑ Unknown test
org.eclipse.tycho.test.product.ProductTypesTest ‑ Unknown test
org.eclipse.tycho.test.product.Tycho188P2EnabledRcpTest ‑ Unknown test
:recycle: This comment has been updated with latest results.
@laeubi updated with latest main
There are already a bunch of conflicts and the patch is huge. Would you please submit it in smaller chunks so things can be actually merged?
@laeubi you ported these or should I try to rebase?
@cstamas I have ported some of the changes (but not all) and at least sometimes look at your changes to get an idea how to convert things, so if you want to take the effort a rebase would be useful.
What @akurtakov want to say is maybe its better to just "deplexus" one little part/component (so it can even be merged) instead of one big change but you can of course decide.