Limit the packaging types supported for which Tycho can create PURLs

[ptziegler]

Tycho should only be able to calculate package URLs for the following packaging types:

• eclipse-plugin
• eclipse-test-plugin
• eclipse-feature
• eclipse-repository
• p2-maven-repository

This avoids issues when the e.g. the target definition is defined in its own module or the the reactor contains non-Tycho packaging types (jar/pom/bundle/...),

[ptziegler]

The test will likely fail because the current implementation can't handle multiple test fragments. But this should be fixed with https://github.com/eclipse-tycho/tycho/pull/3913.

[github-actions[bot]]

Test Results

  600 files  ±0    600 suites  ±0   4h 17m 23s :stopwatch: + 7m 3s   429 tests ±0    422 :white_check_mark: +6   7 :zzz: ±0  0 :x:  - 3  1 287 runs  ±0  1 265 :white_check_mark: +6  22 :zzz: ±0  0 :x:  - 3 

Results for commit 9208f1d0. ± Comparison against base commit 4b50ecfd.

:recycle: This comment has been updated with latest results.

[laeubi]

@ptziegler do you plan to finish this one? There could probably be a new release coming at the end of the Platform release cycle.

[ptziegler]

@laeubi My apologies. I still had it on my to-do list but it just kept getting pushed back. I still want to finish this thing and ideally, I'll try to have a look throughout this week, to figure out what's going wrong with the test.

[ptziegler]

I went over this again and I think it's cleaner to make the project packaging types for which the Tycho model convert is used configurable, rather than hard-coding a set of types.

[ptziegler]

The tests work locally, let's hope Jenkins agrees as well.

[ptziegler]

Hm... of course that's the problem; The log file is simply getting too big. Because the test is executed on debug level, everything that is logged by CycloneDX will show up in the error log. And this is just too much for the test suite to handle.

[ptziegler]

A log file with size 6.1GB... dear lord.

[merks]

It’s probably rife with important and relevant details that you will wish to peruse carefully and fully.

[ptziegler]

The remaining test failure seems unrelated. To keep things simple, I've removed the debug flag for the SBOM tests, which should drastically reduce the size of the build log.

[laeubi]

@ptziegler should this be backported to Tycho 4 branch? If yes please add the label to PR. I have now rebased and enabled automerge.

[ptziegler]

@laeubi

If would be great if this could be back-ported, just to have a consistent behavior accross the board. But I fear I don't have permission to add any labels to this PR.

[eclipse-tycho-bot]

💚 All backports created successfully

Status	Branch	Result
✅	tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details