tycho Update maven-verifier to 2.x

Dec 08 '22 06:12 laeubi

Test Results

356 files ±0 356 suites ±0 2h 18m 39s :stopwatch: - 14m 5s 326 tests ±0 311 :heavy_check_mark: -   5   9 :zzz: ±0 2 :x: +2 4 :fire: +3 652 runs ±0 622 :heavy_check_mark: - 10 19 :zzz: ±0 4 :x: +4 7 :fire: +6

For more details on these failures and errors, see this check.

Results for commit bc68ade5. ± Comparison against base commit 95199fa8.

:recycle: This comment has been updated with latest results.

Dec 08 '22 12:12 github-actions[bot]

I got the verifier update successful now with only a few exceptions, so if anyone like to help with this it would be welcome, at the moment I have no idea what can cause this maybe something with passing the arguments.

Dec 08 '22 15:12 laeubi

@akurtakov maybe something you can help with as well after M1?

I got most things fixed now but there are 5 failing test left after the upgrade to Maven Verifier 2.x I just don't understand what might cause this change in behavior .. but probably we just see a bug here that was not discovered previously?

The most notable changes for Verifier 2.x is that method names changed and arguments are no longer parsed and passed "as is" but I can't see why it should make a difference here, still a second pair of eyes might reveal something.

Next thing is that Verifier 2 executes in the same process by default instead of forking, I have disabled that so we always fork because some test don't work well with it, so it should not be an issue here.

Dec 14 '22 08:12 laeubi

I have the will but no promises :)

Dec 14 '22 08:12 akurtakov

Rebased...

Jan 29 '23 06:01 laeubi

Maybe one should first finish this one as a smaller increment:

https://github.com/eclipse-tycho/tycho/pull/1257

May 18 '23 04:05 laeubi

@dependabot rebase

Sep 21 '23 13:09 akurtakov

@dependabot rebase

This is not a dependabot PR ;-)

I can try to rebase this and resolve conflicts but last time there where still some testfailures du to the upgrade so someone must be look into this if we want to upgrade.

Sep 23 '23 12:09 laeubi

I would probably not find time to look into it as it's just M1 but I'll try to handle some of the deprecations done in this PR separately so it becomes less of a churn.

Sep 27 '23 06:09 akurtakov