Add user-properties for tycho-surefire 'useUIThread' and 'useUIHarness'

[HannesWell]

This allows to configure useUIHarness and useUIThread of the tycho-surefire-plugin via properties, for example on the command-line or via corresponding pom.model.property.* entries in the build.properties.

At least for Eclipse Platform projects setting the mentioned properties is/was sometimes the only reason to have a pom.xml for a test plugin. One could work make such properties available by adding the following snippet to the root pom, but this little change makes even that obsolete.

  <properties>
    <tycho.surefire.useUIHarness>false</tycho.surefire.useUIHarness>
    <tycho.surefire.useUIThread>true</tycho.surefire.useUIThread>
  </properties>

    <pluginManagement>
      <plugins>
        <plugin>
          <groupId>org.eclipse.tycho</groupId>
          <artifactId>tycho-surefire-plugin</artifactId>
          <configuration>
            <useUIHarness>${tycho.surefire.useUIHarness}</useUIHarness>
            <useUIThread>${tycho.surefire.useUIThread}</useUIThread>
          </configuration>
        </plugin>
      </plugins>
    </pluginManagement>

[github-actions[bot]]

Test Results

332 files  ±0  332 suites  ±0   2h 13m 56s :stopwatch: + 10m 11s 295 tests ±0  289 :heavy_check_mark: ±0  4 :zzz: ±0  0 :x: ±0  2 :fire: ±0  590 runs  ±0  579 :heavy_check_mark: ±0  9 :zzz: ±0  0 :x: ±0  2 :fire: ±0 

For more details on these errors, see this check.

Results for commit b394a028. ± Comparison against base commit ee75ec98.

:recycle: This comment has been updated with latest results.

[laeubi]

Please ad a hint to the Release notes as part of this PR as well.

[HannesWell]

Please ad a hint to the Release notes as part of this PR as well.

Done.

[HannesWell]

Since the master is now prepare for Tycho 4.0, do we still publish Tycho 3.1? I think this is simple to back-port and could go on the tycho-3.0.x/tycho-3.1.x (if there will be one) branch?

[mickaelistria]

Tycho 3.1 should not be released in current state because it's not backward compatible with Tycho 3.0. If one wants to release Tycho 3.1, they need to revert the non-compatible changes.

[akurtakov]

I would say keep master for 4.0 and backport to 3.0 branch for 3.0.1 release.

[HannesWell]

Tycho 3.1 should not be released in current state because it's not backward compatible with Tycho 3.0. If one wants to release Tycho 3.1, they need to revert the non-compatible changes.

Agree.

I would say keep master for 4.0 and backport to 3.0 branch for 3.0.1 release.

Sounds good. WILCO.

[laeubi]

Since the master is now prepare for Tycho 4.0, do we still publish Tycho 3.1?

I don't plan any 3.1 release, if anyone wants to do so branching from the 3.0.x branch seems most appropriate. As this is not a regression or required (you presented already a possible workaround) I even don't seen an immediate need for a release just for this feature.

[laeubi]

Jenkins fail due to: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1390

[HannesWell]

The current failures seem to be unrelated to this change. Do they occurs in other PRs as well?

[laeubi]

@HannesWell can you rebase the PR? That should trigger a new build and hopefully now with working Jenkins ...

[HannesWell]

@HannesWell can you rebase the PR? That should trigger a new build and hopefully now with working Jenkins ...

Sure, lets see/hope that this helps. :) In general I only would expect a failure if the newly introduced properties were used in a different context.

[HannesWell]

The two test failures also occur on the master branch. So this is ready to go. 🚀