tycho icon indicating copy to clipboard operation
tycho copied to clipboard

Issue 309 Add Integration test for updating pom version

Open DieterMai opened this issue 3 years ago • 2 comments

Added 2 tests to verify the update of the pom version to the manifest version.

testUpdatePomOfPomThatIsNamedPomXml()

  • This test verifies the behavior for poms named 'pom.xml'

testUpdatePomOfPomThatIsNotNamedPomXml()

  • This test verifies the behavior for poms that are not called 'pom.xml'

  • Fixed some errors in CONTRIBUTING.md

DieterMai avatar Sep 15 '22 23:09 DieterMai

@DieterMai do you plan to propose a fix for this?

laeubi avatar Sep 16 '22 05:09 laeubi

Test Results

324 files  324 suites   2h 13m 2s :stopwatch: 292 tests 287 :heavy_check_mark: 4 :zzz: 0 :x: 1 :fire: 584 runs  573 :heavy_check_mark: 9 :zzz: 0 :x: 2 :fire:

For more details on these errors, see this check.

Results for commit 4459afa6.

github-actions[bot] avatar Sep 16 '22 06:09 github-actions[bot]

@DieterMai can you resolve the conflicts, and rebase on top of current master?

laeubi avatar May 18 '23 04:05 laeubi

Hi @laeubi . Its a long time since i worked on this. As far as i remember the last state was that the update version plugin failed to do its job except for the most simple use cases. My fix only fixed some of that.

The issues with the update version plugin exist since it was written. Yet nobody besides me seem to complain. Do you know if this plugin is actually used? Because if not, I'm am not motivated to invest time. If it is used and a fix for its issues appreciated by the community, I'm happy to continue.

DieterMai avatar May 18 '23 08:05 DieterMai

@DieterMai it is an official plugin and I at least know some projects using it (include eclipse-platform), sadly the test-coverage is quite low, so every test-case (and of course fixes) are of course welcome.

By the way you might want to split the PR e.g in one part that already works, and one with the part that is currently not working + a proposed fix.

laeubi avatar May 19 '23 06:05 laeubi