p2.inf is only considered if included in the binary build

[laeubi]

p2.inf is only considered if it is part of the binary build. As the p2.inf infos are only needed to generate the P2 data it should not be necessary to include it at all.

Reproduce:

1. create a feature project
2. create p2.inf inside and define a property
3. if not included in build.properties -> property is missing
4. if included in build.properties -> property is present

[mickaelistria]

That would be welcome. I guess anyone who creates a p2.inf is bitten by this issue of "why aren't the metadata here" and then 1 hour later "damn, I forgot the build.properties...".

The reason for this at the moment is that the p2 pubisher does look for p2.inf inside the artifact it's building and Tycho relies on its default behavior on that matter. One possibility would be to have Tycho programatically generating an org.eclipse.equinox.p2.publisher.eclipse.AdviceFileAdvice when a p2.inf is found and injecting it into the publisher request programatically with IPublisherInfo.addAdvice().

[laeubi]

I guess anyone who creates a p2.inf is bitten by this issue of "why aren't the metadata here" and then 1 hour later "damn, I forgot the build.properties...".

Guess how I found out :-D

One possibility would be to have Tycho programatically generating an org.eclipse.equinox.p2.publisher.eclipse.AdviceFileAdvice when a p2.inf is found and injecting it into the publisher

Yep, something like that, I just wanted to open the ticket without looking at the details so it dont get lost :-)

[ajohnson1]

Thanks for opening this issue - I too was stuck as to why p2.inf with a feature was ignored for my Tycho build.

I had looked at https://github.com/eclipse-tycho/tycho/tree/master/tycho-its/projects/p2Inf.extraUnits/feature which has a p2.inf not mentioned in build.properties, so I didn't think I needed to do so.

[mickaelistria]

@ajohnson1 Would you be interested in trying to contribute a patch?