filex icon indicating copy to clipboard operation
filex copied to clipboard

Add stm32 low level drivers

Open rahmanih opened this issue 1 year ago • 6 comments

rahmanih avatar Mar 26 '24 16:03 rahmanih

Test Results

1 224 tests   1 224 :heavy_check_mark:  24m 30s :stopwatch:        9 suites         0 :zzz:        9 files           0 :x:

Results for commit 0d32a729.

github-actions[bot] avatar Mar 26 '24 16:03 github-actions[bot]

Code Coverage

Package Line Rate Branch Rate Health
default_build_coverage Package 1 99% 98%
Summary 99% (6458 / 6519) 98% (4185 / 4253)

github-actions[bot] avatar Mar 26 '24 16:03 github-actions[bot]

Hi @wickste,

Woud you please review this PR and merge if it is O.K.?

regards Haithem.

rahmanih avatar Mar 27 '24 10:03 rahmanih

Hi @rahmanih ,

I suggest to

  1. add stm32_drivers under fx_drivers folder which regroup other semi-vendor delivred fx drivers
 common
    |_ fx_drivers
       |_ stm32
       |_ nxp...
       |_ ............ 
  1. add a readme file to guide users who start from this files, what to modify to avoid compilation error. (for example #include "stm32XXXX.h" --> #include "stm32h7xx.h")

With regards MAy

ayedm1 avatar Mar 27 '24 12:03 ayedm1

Hi @wickste,

Could you review this PR please?

regards Haithem.

rahmanih avatar Mar 28 '24 09:03 rahmanih

Thank you @rahmanih - this looks good!

I will need to hold off on merging it for the moment as we are still finalizing the new development process. We need to make sure all new contributions are compliant with that process, so we can continue to obtains safety certification for this code base.

wickste avatar Mar 29 '24 00:03 wickste

closing this PR, as it'll be delivered in a separate repository.

rahmanih avatar Jun 20 '24 13:06 rahmanih