theia icon indicating copy to clipboard operation
theia copied to clipboard

TabGroup.viewColumn and Editor.viewColumn are out of sync for the same editor.

Open tsmaeder opened this issue 9 months ago • 3 comments

Bug Description:

When starting up typescript-language-features 1.881 the context key typescript.isManagedFile is never set. Analyzing the problem led to finding out that the extension fails to find the active typescritpt editor due to this comparison failing for the single open editor:

editor.viewColumn === tab.group.viewColumn;

editor.viewColumn is one and tab.group.ViewColumn is 2, but there is only one editor open.

Steps to Reproduce:

n/a

Additional Information

  • Operating System: Windows 11
  • Theia Version: Theia 1.49 master

tsmaeder avatar May 03 '24 15:05 tsmaeder

Remove the workaround from https://github.com/eclipse-theia/theia/pull/13673 once we have a fix here.

tsmaeder avatar May 05 '24 06:05 tsmaeder

Turns out this problem leads to pretty much all commands from typescript-language-features being disabled, even stuff that is not context dependent like "restart tsserver".

tsmaeder avatar Jun 12 '24 12:06 tsmaeder

https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/ui/activeJsTsEditorTracker.ts#L64

tsmaeder avatar Jun 12 '24 12:06 tsmaeder