theia icon indicating copy to clipboard operation
theia copied to clipboard

VSX Extensions: When uninstalling an extension it will delete the same builtin extension if exists too

Open safisa opened this issue 10 months ago • 1 comments

Bug Description:

Hi, A very problematic issue on extension uninstallation, which I hope is clear in the steps to reproduce below.

Steps to Reproduce:

  1. add for example redhat java extension version 1.26 to your Theia builtin extensions
  2. restart your Theia browser to load the new builtin extension
  3. install a newer version is the builtin one from open-vsx or from vsix file
  4. now uninstall it
  5. reload the page
  6. you will see that the built-in extension is also deleted from builtin folder and not only the deployed one !!!

You can also reproduce it from a similar flow in the ticket I just opened: https://github.com/eclipse-theia/theia/issues/13596 by uninstalling the new java plugin installed by the test runner dependencies.

Additional Information

  • Operating System: mac
  • Theia Version: 1.48

safisa avatar Apr 11 '24 18:04 safisa

IMO, one should not be able to replace a built-in with a newer one from the UI. Built-ins usually are tied to the exact version of the platform they are running on. To update them, you would update the whole product. Maybe there needs to be a category "pre-installed"? I can see that adopters might want to ship some plugins which are not "built-ins" per se with the product. But that sounds like a job for the installer script, not the "built-in" folder.

tsmaeder avatar Apr 12 '24 13:04 tsmaeder