theia icon indicating copy to clipboard operation
theia copied to clipboard

Quick pick items with icons issue - Theia 1.47

Open safisa opened this issue 11 months ago • 1 comments

Bug Description:

Hi, I have upgraded my Theia extension to the latest 1.47.1 version from 1.45.1, and I got this regression issue when running this command: Terminal --> Run Task... I think it is related to the quick-pick component.

Here is the issue in screenshots:

Theia (latest 1.47.1): image

My custom Theia (1.47.1): image

My custom Theia (1.45.1): image

The issue does not happen in Theia browser example, only on my Theia, I don't know what is causing it. Can anyone help and guide me, where and what can I check to fix it?

Thanks in advance

Additional Information

  • Operating System: Mac
  • Theia Version: Theia 1.47.1

safisa avatar Mar 14 '24 12:03 safisa

It very likely has something to do with the recent Monaco upgrade. https://github.com/eclipse-theia/theia/issues/13449 looks related, maybe this helps?

JonasHelming avatar Mar 14 '24 22:03 JonasHelming

@JonasHelming I found that the issue is related to codicon 0.0.27. I saw that the latest Theia is using version 0.0.35, and mine was using 0.0.27, and there was a breaking change in 0.0.28 (Update display property to use inline-block) that causes this issue. I am not sure why my build did not bring the same codicon version, but once I deleted the yarn.lock file, it brings the latest one. Maybe it is because the Theia core package uses @vscode/codicons: "*" ...

safisa avatar Jun 07 '24 11:06 safisa

you can close this issue

safisa avatar Jun 07 '24 11:06 safisa